Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-27871][SQL][FOLLOW-UP] Remove the conf spark.sql.optimizer.reassignLambdaVariableID.enabled #27334

Closed
wants to merge 1 commit into from

Conversation

gatorsmile
Copy link
Member

What changes were proposed in this pull request?

This PR is to remove the conf

Why are the changes needed?

This rule can be excluded using spark.sql.optimizer.excludedRules without an extra conf

Does this PR introduce any user-facing change?

Yes

How was this patch tested?

N/A

@gatorsmile
Copy link
Member Author

cc @cloud-fan

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM (Pending Jenkins)

@SparkQA
Copy link

SparkQA commented Jan 23, 2020

Test build #117283 has finished for PR 27334 at commit 2dd0e39.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds no public classes.

@cloud-fan
Copy link
Contributor

retest this please

@SparkQA
Copy link

SparkQA commented Jan 23, 2020

Test build #117288 has finished for PR 27334 at commit 2dd0e39.

  • This patch fails SparkR unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@cloud-fan
Copy link
Contributor

Seem like CRAN issue again: checking CRAN incoming feasibility ...Error in .check_package_CRAN_incoming(pkgdir)

It's unrelated to this PR, I'm merging it to master, thanks!

@cloud-fan cloud-fan closed this in ffd435b Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants