[SPARK-27083][SQL][FOLLOW-UP] Rename spark.sql.subquery.reuse to spark.sql.execution.subquery.reuse.enabled #27346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maropu
approved these changes
Jan 23, 2020
|
Thanks! Merged to master. |
|
Test build #117320 has finished for PR 27346 at commit
|
cloud-fan
reviewed
Feb 10, 2020
| @@ -1053,7 +1053,7 @@ object SQLConf { | |||
| .booleanConf | |||
| .createWithDefault(true) | |||
|
|
|||
| val SUBQUERY_REUSE_ENABLED = buildConf("spark.sql.subquery.reuse") | |||
| val SUBQUERY_REUSE_ENABLED = buildConf("spark.sql.execution.subquery.reuse.enabled") | |||
There was a problem hiding this comment.
now this is inconsistent with the exchange reuse: spark.sql.exchange.reuse
cc @rxin @maryannxue
There was a problem hiding this comment.
It seems we currently have the three patterns for boolean configs;
- spark.sql.xxx.enabled, e.g.,
spark.sql.optimizer.dynamicPartitionPruning.enabled - spark.sql.enableXXX, e.g.,
spark.sql.inMemoryColumnarStorage.enableVectorizedReader - the names without
enabled, e.g.,spark.sql.exchange.reuse
We need a consistent rule for these boolean configs?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR is to rename spark.sql.subquery.reuse to spark.sql.execution.subquery.reuse.enabled
Why are the changes needed?
Make it consistent and clear.
Does this PR introduce any user-facing change?
N/A. This is a new conf added in Spark 3.0
How was this patch tested?
N/A