[SPARK-30192][SQL][FOLLOWUP] Rename SINGLETON to INSTANCE #27409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you review this, @cloud-fan and @brkyvz ? |
|
Test build #117602 has finished for PR 27409 at commit
|
|
Retest this please. |
HyukjinKwon
approved these changes
Jan 31, 2020
|
Thank you for review and approval, @HyukjinKwon . |
cloud-fan
approved these changes
Jan 31, 2020
|
Thank you for review and approval, @cloud-fan . |
|
Test build #117611 has finished for PR 27409 at commit
|
|
Merged to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR renames a variable
SINGLETONtoINSTANCE.Why are the changes needed?
This is a minor change for consistency with the other parts.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the existing tests.