Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-30695][BUILD] Upgrade Apache ORC to 1.5.9 #27421

Closed
wants to merge 2 commits into from
Closed

[SPARK-30695][BUILD] Upgrade Apache ORC to 1.5.9 #27421

wants to merge 2 commits into from

Conversation

dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Jan 31, 2020

What changes were proposed in this pull request?

This PR aims to upgrade to Apache ORC 1.5.9.

  • For hive-2.3 profile, we need to upgrade hive-storage-api from 2.6.0 to 2.7.1.
  • For hive-1.2 profile, ORC library with classifier nohive already shaded it. So, there is no change.

Why are the changes needed?

This will bring the latest bug fixes. The following is the full release note.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Pass the Jenkins with the existing tests.

Here is the summary.

  1. Hive 1.2 + Hadoop 2.7 passed. (here)
  2. Hive 2.3 + Hadoop 2.7 passed. (here)

@dongjoon-hyun dongjoon-hyun changed the title [SPARK-30695][BUILD] Upgrade Apache ORC to 1.5.9 [SPARK-30695][BUILD][test-hive1.2] Upgrade Apache ORC to 1.5.9 Jan 31, 2020
@dongjoon-hyun
Copy link
Member Author

Retest this please.

@dongjoon-hyun dongjoon-hyun changed the title [SPARK-30695][BUILD][test-hive1.2] Upgrade Apache ORC to 1.5.9 [SPARK-30695][BUILD][test-hadoop3.2][test-java11] Upgrade Apache ORC to 1.5.9 Jan 31, 2020
@SparkQA
Copy link

SparkQA commented Jan 31, 2020

Test build #117677 has finished for PR 27421 at commit afcce15.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA

This comment has been minimized.

@dongjoon-hyun dongjoon-hyun changed the title [SPARK-30695][BUILD][test-hadoop3.2][test-java11] Upgrade Apache ORC to 1.5.9 [SPARK-30695][BUILD][test-hive1.2] Upgrade Apache ORC to 1.5.9 Jan 31, 2020
@dongjoon-hyun dongjoon-hyun changed the title [SPARK-30695][BUILD][test-hive1.2] Upgrade Apache ORC to 1.5.9 [SPARK-30695][BUILD] Upgrade Apache ORC to 1.5.9 Jan 31, 2020
@dongjoon-hyun
Copy link
Member Author

Retest this please.

@SparkQA
Copy link

SparkQA commented Jan 31, 2020

Test build #117676 has finished for PR 27421 at commit 1c1f13b.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun
Copy link
Member Author

dongjoon-hyun commented Jan 31, 2020

Here is the summary.

  1. Hive 1.2 + Hadoop 2.7 passed. (here)
  2. Hive 2.3 + Hadoop 2.7 seems to fail at irrelevant org.apache.spark.sql.hive.thriftserver.CliSuite.SPARK-28840 test --jars command test flakiness.
  3. Hive 2.3 + Hadoop 3.2 + JDK11 failed at irrelevant Python mllib test flakiness.

For (2) and (3), I rebased this PR to the master and verified that those tests pass locally.

@dongjoon-hyun dongjoon-hyun changed the title [SPARK-30695][BUILD] Upgrade Apache ORC to 1.5.9 [SPARK-30695][BUILD][test-hadoop3.2][test-java11] Upgrade Apache ORC to 1.5.9 Jan 31, 2020
@dongjoon-hyun
Copy link
Member Author

Retest this please.

@dongjoon-hyun
Copy link
Member Author

I created a testing PR for Python mllib flakiness in JDK11 environment.

@SparkQA
Copy link

SparkQA commented Feb 1, 2020

Test build #117691 has finished for PR 27421 at commit afcce15.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Feb 1, 2020

Test build #117685 has finished for PR 27421 at commit afcce15.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun
Copy link
Member Author

Hi, @viirya . Could you review this PR?

@@ -469,6 +469,7 @@ xmlenc:xmlenc
net.sf.py4j:py4j
org.jpmml:pmml-model
org.jpmml:pmml-schema
org.threeten:threeten-extra
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, this is added since 1.5.9?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. It is~

@dongjoon-hyun
Copy link
Member Author

Thank you for review and approval.

@dongjoon-hyun dongjoon-hyun changed the title [SPARK-30695][BUILD][test-hadoop3.2][test-java11] Upgrade Apache ORC to 1.5.9 [SPARK-30695][BUILD] Upgrade Apache ORC to 1.5.9 Feb 1, 2020
@dongjoon-hyun
Copy link
Member Author

Merged to master.

@dongjoon-hyun dongjoon-hyun deleted the SPARK-ORC-1.5.9 branch February 1, 2020 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants