[SPARK-29543][SS][FOLLOWUP] Move spark.sql.streaming.ui.* configs to StaticSQLConf
#27425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
changed the title
spark.sql.streaming.ui.* configs to StaticSQLConf
|
Test build #117709 has finished for PR 27425 at commit
|
zsxwing
requested changes
Feb 2, 2020
|
|
||
| val STREAMING_UI_ENABLED = | ||
| buildStaticConf("spark.sql.streaming.ui.enabled") | ||
| .doc("Whether to run the structured streaming UI for the Spark application.") |
There was a problem hiding this comment.
nit: Whether to run the Structured Streaming Web UI for the Spark application when the Spark Web UI is enabled.
|
|
||
| val STREAMING_UI_RETAINED_PROGRESS_UPDATES = | ||
| buildStaticConf("spark.sql.streaming.ui.retainedProgressUpdates") | ||
| .doc("The number of progress updates to retain for a streaming query for structured " + |
There was a problem hiding this comment.
nit: structured streaming ui -> Structured Streaming UI
|
|
||
| val STREAMING_UI_RETAINED_QUERIES = | ||
| buildStaticConf("spark.sql.streaming.ui.retainedQueries") | ||
| .doc("The number of inactive queries to retain for structured streaming ui.") |
There was a problem hiding this comment.
Thanks, doc changes done in d763abb.
| @@ -146,12 +146,14 @@ private[sql] class SharedState( | |||
| */ | |||
| lazy val streamingQueryStatusListener: Option[StreamingQueryStatusListener] = { | |||
| val sqlConf = SQLConf.get | |||
There was a problem hiding this comment.
nit: we can remove this and use conf in this class directly.
There was a problem hiding this comment.
Thanks, then StreamingQueryStatusListener need a little change, done in d763abb.
|
Test build #117740 has finished for PR 27425 at commit
|
|
Thanks for this work, LGTM. |
|
Thanks! Merging to master and branch-3.0. |
asfgit
pushed a commit
that referenced
this pull request
Feb 3, 2020
…o StaticSQLConf ### What changes were proposed in this pull request? Put the configs below needed by Structured Streaming UI into StaticSQLConf: - spark.sql.streaming.ui.enabled - spark.sql.streaming.ui.retainedProgressUpdates - spark.sql.streaming.ui.retainedQueries ### Why are the changes needed? Make all SS UI configs consistent with other similar configs in usage and naming. ### Does this PR introduce any user-facing change? Yes, add new static config `spark.sql.streaming.ui.retainedProgressUpdates`. ### How was this patch tested? Existing UT. Closes #27425 from xuanyuanking/SPARK-29543-follow. Authored-by: Yuanjian Li <xyliyuanjian@gmail.com> Signed-off-by: Shixiong Zhu <zsxwing@gmail.com> (cherry picked from commit a4912ce) Signed-off-by: Shixiong Zhu <zsxwing@gmail.com>
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Put the configs below needed by Structured Streaming UI into StaticSQLConf:
Why are the changes needed?
Make all SS UI configs consistent with other similar configs in usage and naming.
Does this PR introduce any user-facing change?
Yes, add new static config
spark.sql.streaming.ui.retainedProgressUpdates.How was this patch tested?
Existing UT.