[SPARK-30775][DOC] Improve the description of executor metrics in the monitoring documentation. #27526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dongjoon-hyun given your work on #25770 you may want to have a look at this? |
LucaCanali
force-pushed
the
docPrometheusMetricsFollowupSpark29064
branch
from
f4b6064
to
d39cead
Compare
|
ok to test |
dongjoon-hyun
requested changes
Mar 30, 2020
|
Test build #120569 has finished for PR 27526 at commit
|
|
Test build #120589 has finished for PR 27526 at commit
|
|
|
Test build #120594 has finished for PR 27526 at commit
|
dongjoon-hyun
approved these changes
Mar 31, 2020
There was a problem hiding this comment.
Thank you for updating, @LucaCanali . +1, LGTM.
Merged to master.
Since RC1 tag is already created, I will cherry-pick this to branch-3.0 after RC1 failure.
|
Thank you @dongjoon-hyun |
dongjoon-hyun
pushed a commit
that referenced
this pull request
Mar 31, 2020
… monitoring documentation ### What changes were proposed in this pull request? This PR (SPARK-30775) aims to improve the description of the executor metrics in the monitoring documentation. ### Why are the changes needed? Improve and clarify monitoring documentation by: - adding reference to the Prometheus end point, as implemented in [SPARK-29064] - extending the list and descripion of executor metrics, following up from [SPARK-27157] ### Does this PR introduce any user-facing change? Documentation update. ### How was this patch tested? n.a. Closes #27526 from LucaCanali/docPrometheusMetricsFollowupSpark29064. Authored-by: Luca Canali <luca.canali@cern.ch> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit aa98ac5) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
sjincho
pushed a commit
to sjincho/spark
that referenced
this pull request
Apr 15, 2020
… monitoring documentation ### What changes were proposed in this pull request? This PR (SPARK-30775) aims to improve the description of the executor metrics in the monitoring documentation. ### Why are the changes needed? Improve and clarify monitoring documentation by: - adding reference to the Prometheus end point, as implemented in [SPARK-29064] - extending the list and descripion of executor metrics, following up from [SPARK-27157] ### Does this PR introduce any user-facing change? Documentation update. ### How was this patch tested? n.a. Closes apache#27526 from LucaCanali/docPrometheusMetricsFollowupSpark29064. Authored-by: Luca Canali <luca.canali@cern.ch> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR (SPARK-30775) aims to improve the description of the executor metrics in the monitoring documentation.
Why are the changes needed?
Improve and clarify monitoring documentation by:
Does this PR introduce any user-facing change?
Documentation update.
How was this patch tested?
n.a.