[SPARK-30819][SPARKR][ML] Add FMRegressor wrapper to SparkR #27571

zero323 · 2020-02-13T23:27:24Z

What changes were proposed in this pull request?

This pull request adds SparkR wrapper for FMRegressor:

Supporting org.apache.spark.ml.r.FMRegressorWrapper.
FMRegressionModel S4 class.
Corresponding spark.fmRegressor, predict, summary and write.ml generics.
Corresponding docs and tests.

Why are the changes needed?

Feature parity.

Does this PR introduce any user-facing change?

No (new API).

How was this patch tested?

New unit tests.

SparkQA · 2020-02-13T23:32:34Z

Test build #118381 has finished for PR 27571 at commit 55f6761.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class FMRegressorWrapperWriter(instance: FMRegressorWrapper) extends MLWriter
class FMRegressorWrapperReader extends MLReader[FMRegressorWrapper]

SparkQA · 2020-02-14T01:26:55Z

Test build #118382 has finished for PR 27571 at commit 9639e14.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

zero323 · 2020-02-14T11:34:41Z

Jenkins, retest this please.

SparkQA · 2020-02-14T13:18:10Z

Test build #118424 has finished for PR 27571 at commit 9639e14.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

SparkQA · 2020-02-14T20:11:17Z

Test build #118444 has finished for PR 27571 at commit 26aae37.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

SparkQA · 2020-02-16T02:14:22Z

Test build #118484 has finished for PR 27571 at commit 6093e03.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

R/pkg/R/mllib_regression.R

examples/src/main/r/ml/fmRegressor.R

mllib/src/main/scala/org/apache/spark/ml/r/FMRegressorWrapper.scala

zero323 · 2020-02-16T12:02:09Z

Thanks for the reviews @huaxingao!

SparkQA · 2020-02-16T12:03:28Z

Test build #118499 has finished for PR 27571 at commit c0127e0.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

SparkQA · 2020-02-23T00:57:42Z

Test build #118823 has finished for PR 27571 at commit 19e6126.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

SparkQA · 2020-02-23T11:15:22Z

Test build #118831 has finished for PR 27571 at commit 1228f63.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

SparkQA · 2020-03-03T18:17:05Z

Test build #119240 has finished for PR 27571 at commit 4c5b2a5.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

zero323 · 2020-03-03T21:21:38Z

Retest this please.

SparkQA · 2020-03-03T22:53:16Z

Test build #119254 has finished for PR 27571 at commit 4c5b2a5.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

SparkQA · 2020-03-04T20:25:01Z

Test build #119331 has finished for PR 27571 at commit 22b9ae5.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

zero323 · 2020-03-04T21:54:56Z

Retest this please.

SparkQA · 2020-03-04T23:10:54Z

Test build #119341 has finished for PR 27571 at commit 22b9ae5.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

SparkQA · 2020-03-08T03:09:15Z

Test build #119524 has finished for PR 27571 at commit 0adb2cf.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

SparkQA · 2020-03-08T22:19:33Z

Test build #119540 has finished for PR 27571 at commit e5f617d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

SparkQA · 2020-03-08T23:24:24Z

Test build #119544 has finished for PR 27571 at commit 82b99c1.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

srowen · 2020-04-07T14:12:23Z

@zero323 I imagine this one is good to go too but now has a merge conflict, b/c FMClassifier was merged

SparkQA · 2020-04-07T16:58:45Z

Test build #120920 has finished for PR 27571 at commit 7875539.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

SparkQA · 2020-04-07T18:21:45Z

Test build #120925 has finished for PR 27571 at commit 7875539.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

R/pkg/R/mllib_regression.R

mllib/src/main/scala/org/apache/spark/ml/r/FMRegressorWrapper.scala

huaxingao · 2020-04-07T20:46:33Z

LGTM except a few minor comments.

SparkQA · 2020-04-09T06:47:47Z

Test build #121001 has finished for PR 27571 at commit cb7ec6a.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class FMRegressorWrapperWriter(instance: FMRegressorWrapper) extends MLWriter
class FMRegressorWrapperReader extends MLReader[FMRegressorWrapper]

SparkQA · 2020-04-09T06:48:07Z

Test build #121002 has finished for PR 27571 at commit 2d1f8b1.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class FMRegressorWrapperWriter(instance: FMRegressorWrapper) extends MLWriter
class FMRegressorWrapperReader extends MLReader[FMRegressorWrapper]

srowen · 2020-04-10T00:38:20Z

merged to master

zero323 · 2020-04-10T01:51:21Z

Thanks @huaxingao @srowen!

### What changes were proposed in this pull request? This pull request adds SparkR wrapper for `FMRegressor`: - Supporting ` org.apache.spark.ml.r.FMRegressorWrapper`. - `FMRegressionModel` S4 class. - Corresponding `spark.fmRegressor`, `predict`, `summary` and `write.ml` generics. - Corresponding docs and tests. ### Why are the changes needed? Feature parity. ### Does this PR introduce any user-facing change? No (new API). ### How was this patch tested? New unit tests. Closes apache#27571 from zero323/SPARK-30819. Authored-by: zero323 <mszymkiewicz@gmail.com> Signed-off-by: Sean Owen <srowen@gmail.com>

zero323 force-pushed the SPARK-30819 branch from 9639e14 to 26aae37 Compare February 14, 2020 18:46

zero323 force-pushed the SPARK-30819 branch from 26aae37 to 6093e03 Compare February 15, 2020 20:14

huaxingao reviewed Feb 16, 2020

View reviewed changes

zero323 force-pushed the SPARK-30819 branch from 19e6126 to 1228f63 Compare February 23, 2020 09:58

dongjoon-hyun added ML SPARKR labels Feb 28, 2020

srowen mentioned this pull request Mar 2, 2020

[SPARK-30820][SPARKR][ML] Add FMClassifier to SparkR #27570

Closed

zero323 closed this Mar 4, 2020

zero323 reopened this Mar 4, 2020

zero323 force-pushed the SPARK-30819 branch from 22b9ae5 to 0adb2cf Compare March 8, 2020 01:51

zero323 force-pushed the SPARK-30819 branch from 0adb2cf to e5f617d Compare March 8, 2020 20:56

zero323 force-pushed the SPARK-30819 branch from 82b99c1 to 7875539 Compare April 7, 2020 15:26

huaxingao reviewed Apr 7, 2020

View reviewed changes

R/pkg/R/mllib_regression.R Outdated Show resolved Hide resolved

mllib/src/main/scala/org/apache/spark/ml/r/FMRegressorWrapper.scala Outdated Show resolved Hide resolved

mllib/src/main/scala/org/apache/spark/ml/r/FMRegressorWrapper.scala Outdated Show resolved Hide resolved

zero323 force-pushed the SPARK-30819 branch from 7875539 to cb7ec6a Compare April 9, 2020 05:13

Add FMRegressor

2d1f8b1

zero323 force-pushed the SPARK-30819 branch from cb7ec6a to 2d1f8b1 Compare April 9, 2020 05:21

srowen closed this in 697fe91 Apr 10, 2020

zero323 deleted the SPARK-30819 branch April 10, 2020 01:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[SPARK-30819][SPARKR][ML] Add FMRegressor wrapper to SparkR #27571

[SPARK-30819][SPARKR][ML] Add FMRegressor wrapper to SparkR #27571

zero323 commented Feb 13, 2020

SparkQA commented Feb 13, 2020

SparkQA commented Feb 14, 2020

zero323 commented Feb 14, 2020

SparkQA commented Feb 14, 2020

SparkQA commented Feb 14, 2020

SparkQA commented Feb 16, 2020

zero323 commented Feb 16, 2020

SparkQA commented Feb 16, 2020

SparkQA commented Feb 23, 2020

SparkQA commented Feb 23, 2020

SparkQA commented Mar 3, 2020

zero323 commented Mar 3, 2020

SparkQA commented Mar 3, 2020

SparkQA commented Mar 4, 2020

zero323 commented Mar 4, 2020

SparkQA commented Mar 4, 2020

SparkQA commented Mar 8, 2020

SparkQA commented Mar 8, 2020

SparkQA commented Mar 8, 2020

srowen commented Apr 7, 2020

SparkQA commented Apr 7, 2020

SparkQA commented Apr 7, 2020

huaxingao commented Apr 7, 2020

SparkQA commented Apr 9, 2020

SparkQA commented Apr 9, 2020

srowen commented Apr 10, 2020

zero323 commented Apr 10, 2020

[SPARK-30819][SPARKR][ML] Add FMRegressor wrapper to SparkR #27571

[SPARK-30819][SPARKR][ML] Add FMRegressor wrapper to SparkR #27571

Conversation

zero323 commented Feb 13, 2020

What changes were proposed in this pull request?

Why are the changes needed?

Does this PR introduce any user-facing change?

How was this patch tested?

SparkQA commented Feb 13, 2020

SparkQA commented Feb 14, 2020

zero323 commented Feb 14, 2020

SparkQA commented Feb 14, 2020

SparkQA commented Feb 14, 2020

SparkQA commented Feb 16, 2020

zero323 commented Feb 16, 2020

SparkQA commented Feb 16, 2020

SparkQA commented Feb 23, 2020

SparkQA commented Feb 23, 2020

SparkQA commented Mar 3, 2020

zero323 commented Mar 3, 2020

SparkQA commented Mar 3, 2020

SparkQA commented Mar 4, 2020

zero323 commented Mar 4, 2020

SparkQA commented Mar 4, 2020

SparkQA commented Mar 8, 2020

SparkQA commented Mar 8, 2020

SparkQA commented Mar 8, 2020

srowen commented Apr 7, 2020

SparkQA commented Apr 7, 2020

SparkQA commented Apr 7, 2020

huaxingao commented Apr 7, 2020

SparkQA commented Apr 9, 2020

SparkQA commented Apr 9, 2020

srowen commented Apr 10, 2020

zero323 commented Apr 10, 2020