[SPARK-30793][SQL][2.4] Fix truncations of timestamps before the epoch to minutes and seconds #27611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloud-fan
approved these changes
Feb 17, 2020
|
Test build #118593 has finished for PR 27611 at commit
|
|
jenkins, retest this, please |
|
Test build #118600 has finished for PR 27611 at commit
|
cloud-fan
pushed a commit
that referenced
this pull request
Feb 18, 2020
…h to minutes and seconds ### What changes were proposed in this pull request? In the PR (a backport of #27543), I propose to replace `%` by `Math.floorMod` in `DateTimeUtils.truncTimestamp` for the `SECOND` and `MINUTE` levels. ### Why are the changes needed? This fixes the issue of incorrect truncation of timestamps before the epoch `1970-01-01T00:00:00.000000Z` to the `SECOND` and `MINUTE` levels. For example, timestamps after the epoch are truncated by cutting off the rest part of the timestamp: ```sql spark-sql> select date_trunc('SECOND', '2020-02-11 00:01:02.123'); 2020-02-11 00:01:02 ``` but seconds in the truncated timestamp before the epoch are increased by 1: ```sql spark-sql> select date_trunc('SECOND', '1960-02-11 00:01:02.123'); 1960-02-11 00:01:03 ``` ### Does this PR introduce any user-facing change? Yes. After the changes, the example above outputs correct result: ```sql spark-sql> select date_trunc('SECOND', '1960-02-11 00:01:02.123'); 1960-02-11 00:01:02 ``` ### How was this patch tested? Added new tests to `DateFunctionsSuite`. Closes #27611 from MaxGekk/fix-second-minute-truc-2.4. Authored-by: Maxim Gekk <max.gekk@gmail.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
|
thanks, merging to 2.4! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In the PR (a backport of #27543), I propose to replace
%byMath.floorModinDateTimeUtils.truncTimestampfor theSECONDandMINUTElevels.Why are the changes needed?
This fixes the issue of incorrect truncation of timestamps before the epoch
1970-01-01T00:00:00.000000Zto theSECONDandMINUTElevels. For example, timestamps after the epoch are truncated by cutting off the rest part of the timestamp:but seconds in the truncated timestamp before the epoch are increased by 1:
Does this PR introduce any user-facing change?
Yes. After the changes, the example above outputs correct result:
How was this patch tested?
Added new tests to
DateFunctionsSuite.