[SPARK-27924][SQL][FOLLOW-UP] Improve ANSI SQL Boolean-Predicate #27699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #118940 has finished for PR 27699 at commit
|
|
Test build #118942 has finished for PR 27699 at commit
|
maropu
reviewed
Feb 26, 2020
| @@ -523,34 +523,6 @@ class PredicateSuite extends SparkFunSuite with ExpressionEvalHelper { | |||
| } | |||
|
|
|||
| val row0 = create_row(null) | |||
There was a problem hiding this comment.
Can you move this variable into the test test("isunknown and isnotunknown")?
|
Test build #118956 has finished for PR 27699 at commit
|
|
retest this please |
cloud-fan
approved these changes
Feb 26, 2020
|
Test build #118969 has finished for PR 27699 at commit
|
|
retest this please |
|
Test build #118987 has finished for PR 27699 at commit
|
|
thanks, merging to master/3.0! |
cloud-fan
pushed a commit
that referenced
this pull request
Feb 27, 2020
### What changes were proposed in this pull request? This PR follows #25074 and improves the implement. ### Why are the changes needed? Improve code. ### Does this PR introduce any user-facing change? No ### How was this patch tested? Exists UT Closes #27699 from beliefer/improve-boolean-test. Authored-by: beliefer <beliefer@163.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com> (cherry picked from commit 1515d45) Signed-off-by: Wenchen Fan <wenchen@databricks.com>
sjincho
pushed a commit
to sjincho/spark
that referenced
this pull request
Apr 15, 2020
### What changes were proposed in this pull request? This PR follows apache#25074 and improves the implement. ### Why are the changes needed? Improve code. ### Does this PR introduce any user-facing change? No ### How was this patch tested? Exists UT Closes apache#27699 from beliefer/improve-boolean-test. Authored-by: beliefer <beliefer@163.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR follows #25074 and improves the implement.
Why are the changes needed?
Improve code.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Exists UT