-
Notifications
You must be signed in to change notification settings - Fork 28k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-30964][Core][WebUI] Accelerate InMemoryStore with a new index #27716
Closed
Closed
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
4f93ffc
Accelerate InMemoryStore with a new index
gengliangwang c6c2c82
Fix java style
gengliangwang b0bb448
Alias type
gengliangwang 8969a4d
fix lint java
gengliangwang d50c801
revise
gengliangwang 9cb44c3
revise coding style
gengliangwang da463e9
fix one trivial indent
gengliangwang 753a14a
add comment and revise style
gengliangwang 2ec82df
address comments
gengliangwang 091fb7e
add more comments
gengliangwang e02acc0
revise code style
gengliangwang 491e9eb
fix java lint
gengliangwang c0d3755
fix
gengliangwang File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since there is no document, I still have problems understanding it.
The basic idea is: if the
index
is natural index, we can just look it up in O(1). For other index, we have to do linear scan, extract keys and find matches.The extension here: if the
index
is parent of natural index, get the children natural indexes and do O(1) lookup.However, seems the basic idea is missing? Shall we avoid linear scan if
index
is natural index?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes and no.
I am aware of the natural index is not handled properly here. But all the method calls of this method doesn't pass the natural index in.
There is a simpler API to use in
KVStore
So I think this is minor and I prefer to do it in another PR, since this one is complicated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should probably unify the
delete
method, but it's not related to this PR.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I will do it in another PR.