[SPARK-30908][CORE][DOC] Add version information to the configuration of Kryo #27734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beliefer
commented
Feb 28, 2020
| @@ -22,35 +22,43 @@ import org.apache.spark.network.util.ByteUnit | |||
| private[spark] object Kryo { | |||
|
|
|||
| val KRYO_REGISTRATION_REQUIRED = ConfigBuilder("spark.kryo.registrationRequired") | |||
| .version("1.1.0") | |||
There was a problem hiding this comment.
SPARK-2102, commit ID: efdaeb1#diff-1f81c62dad0e2dfc387a974bb08c497c
beliefer
commented
Feb 28, 2020
| .booleanConf | ||
| .createWithDefault(false) | ||
|
|
||
| val KRYO_USER_REGISTRATORS = ConfigBuilder("spark.kryo.registrator") | ||
| .version("0.5.0") |
There was a problem hiding this comment.
No JIRA ID, commit ID: 91c07a3#diff-792ed56b3398163fa14e8578549d0d98
This is not a release version, do we need to record it?
beliefer
commented
Feb 28, 2020
| .stringConf | ||
| .createOptional | ||
|
|
||
| val KRYO_CLASSES_TO_REGISTER = ConfigBuilder("spark.kryo.classesToRegister") | ||
| .version("1.2.0") |
There was a problem hiding this comment.
SPARK-1813, commit ID: 6bb56fa#diff-529fc5c06b9731c1fbda6f3db60b16aa
beliefer
commented
Feb 28, 2020
| .stringConf | ||
| .toSequence | ||
| .createWithDefault(Nil) | ||
|
|
||
| val KRYO_USE_UNSAFE = ConfigBuilder("spark.kryo.unsafe") | ||
| .version("2.1.0") |
beliefer
commented
Feb 28, 2020
| .booleanConf | ||
| .createWithDefault(false) | ||
|
|
||
| val KRYO_USE_POOL = ConfigBuilder("spark.kryo.pool") | ||
| .version("3.0.0") |
There was a problem hiding this comment.
SPARK-26466, commit ID: 38f0307#diff-a3c6b992784f9abeb9f3047d3dcf3ed9
beliefer
commented
Feb 28, 2020
| .booleanConf | ||
| .createWithDefault(true) | ||
|
|
||
| val KRYO_REFERENCE_TRACKING = ConfigBuilder("spark.kryo.referenceTracking") | ||
| .version("0.8.0") |
There was a problem hiding this comment.
No JIRA ID, commit ID: 0a8cc30#diff-1f81c62dad0e2dfc387a974bb08c497c
beliefer
commented
Feb 28, 2020
| .booleanConf | ||
| .createWithDefault(true) | ||
|
|
||
| val KRYO_SERIALIZER_BUFFER_SIZE = ConfigBuilder("spark.kryoserializer.buffer") | ||
| .version("1.4.0") |
There was a problem hiding this comment.
SPARK-5932, commit ID: 2d222fb#diff-1f81c62dad0e2dfc387a974bb08c497c
beliefer
commented
Feb 28, 2020
| .bytesConf(ByteUnit.KiB) | ||
| .createWithDefaultString("64k") | ||
|
|
||
| val KRYO_SERIALIZER_MAX_BUFFER_SIZE = ConfigBuilder("spark.kryoserializer.buffer.max") | ||
| .version("1.4.0") |
There was a problem hiding this comment.
SPARK-5932, commit ID: 2d222fb#diff-1f81c62dad0e2dfc387a974bb08c497c
|
Test build #119084 has finished for PR 27734 at commit
|
HyukjinKwon
approved these changes
Mar 1, 2020
|
Merged to master. |
|
@HyukjinKwon Thanks for your work. |
HyukjinKwon
pushed a commit
that referenced
this pull request
Apr 5, 2020
… of Kryo ### What changes were proposed in this pull request? 1.Add version information to the configuration of `Kryo`. 2.Update the docs of `Kryo`. I sorted out some information show below. Item name | Since version | JIRA ID | Commit ID | Note -- | -- | -- | -- | -- spark.kryo.registrationRequired | 1.1.0 | SPARK-2102 | efdaeb1#diff-1f81c62dad0e2dfc387a974bb08c497c | spark.kryo.registrator | 0.5.0 | None | 91c07a3#diff-792ed56b3398163fa14e8578549d0d98 | This is not a release version, do we need to record it? spark.kryo.classesToRegister | 1.2.0 | SPARK-1813 | 6bb56fa#diff-529fc5c06b9731c1fbda6f3db60b16aa | spark.kryo.unsafe | 2.1.0 | SPARK-928 | bc167a2#diff-1f81c62dad0e2dfc387a974bb08c497c | spark.kryo.pool | 3.0.0 | SPARK-26466 | 38f0307#diff-a3c6b992784f9abeb9f3047d3dcf3ed9 | spark.kryo.referenceTracking | 0.8.0 | None | 0a8cc30#diff-1f81c62dad0e2dfc387a974bb08c497c | spark.kryoserializer.buffer | 1.4.0 | SPARK-5932 | 2d222fb#diff-1f81c62dad0e2dfc387a974bb08c497c | spark.kryoserializer.buffer.max | 1.4.0 | SPARK-5932 | 2d222fb#diff-1f81c62dad0e2dfc387a974bb08c497c | ### Why are the changes needed? Supplemental configuration version information. ### Does this PR introduce any user-facing change? No ### How was this patch tested? Exists UT Closes #27734 from beliefer/add-version-to-kryo-config. Authored-by: beliefer <beliefer@163.com> Signed-off-by: HyukjinKwon <gurwls223@apache.org>
|
Merged to branch-3.0 too |
sjincho
pushed a commit
to sjincho/spark
that referenced
this pull request
Apr 15, 2020
… of Kryo ### What changes were proposed in this pull request? 1.Add version information to the configuration of `Kryo`. 2.Update the docs of `Kryo`. I sorted out some information show below. Item name | Since version | JIRA ID | Commit ID | Note -- | -- | -- | -- | -- spark.kryo.registrationRequired | 1.1.0 | SPARK-2102 | efdaeb1#diff-1f81c62dad0e2dfc387a974bb08c497c | spark.kryo.registrator | 0.5.0 | None | 91c07a3#diff-792ed56b3398163fa14e8578549d0d98 | This is not a release version, do we need to record it? spark.kryo.classesToRegister | 1.2.0 | SPARK-1813 | 6bb56fa#diff-529fc5c06b9731c1fbda6f3db60b16aa | spark.kryo.unsafe | 2.1.0 | SPARK-928 | bc167a2#diff-1f81c62dad0e2dfc387a974bb08c497c | spark.kryo.pool | 3.0.0 | SPARK-26466 | 38f0307#diff-a3c6b992784f9abeb9f3047d3dcf3ed9 | spark.kryo.referenceTracking | 0.8.0 | None | 0a8cc30#diff-1f81c62dad0e2dfc387a974bb08c497c | spark.kryoserializer.buffer | 1.4.0 | SPARK-5932 | 2d222fb#diff-1f81c62dad0e2dfc387a974bb08c497c | spark.kryoserializer.buffer.max | 1.4.0 | SPARK-5932 | 2d222fb#diff-1f81c62dad0e2dfc387a974bb08c497c | ### Why are the changes needed? Supplemental configuration version information. ### Does this PR introduce any user-facing change? No ### How was this patch tested? Exists UT Closes apache#27734 from beliefer/add-version-to-kryo-config. Authored-by: beliefer <beliefer@163.com> Signed-off-by: HyukjinKwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
1.Add version information to the configuration of
Kryo.2.Update the docs of
Kryo.I sorted out some information show below.
Why are the changes needed?
Supplemental configuration version information.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Exists UT