[SPARK-31012][ML][PySpark][DOCS] Updating ML API docs for 3.0 changes #27762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #119186 has finished for PR 27762 at commit
|
zhengruifeng
reviewed
Mar 3, 2020
| @@ -28,7 +28,8 @@ import org.apache.spark.sql.functions._ | |||
| import org.apache.spark.sql.types.DoubleType | |||
|
|
|||
| /** | |||
| * Evaluator for binary classification, which expects two input columns: rawPrediction and label. | |||
| * Evaluator for binary classification, which expects input columns rawPrediction, label and | |||
There was a problem hiding this comment.
nit: Evaluator for binary classification, which expects input columns: rawPrediction, label and
There was a problem hiding this comment.
Text is OK as is I think, but could quote the column names
There was a problem hiding this comment.
I guess I will leave this as is if that's OK by you two. The other two classes MulticlassClassificationEvaluator and RegressionEvaluator don't quote the column names either. If I change, I will have to change all of them.
zhengruifeng
reviewed
Mar 3, 2020
| @@ -110,7 +110,8 @@ def isLargerBetter(self): | |||
| class BinaryClassificationEvaluator(JavaEvaluator, HasLabelCol, HasRawPredictionCol, HasWeightCol, | |||
| JavaMLReadable, JavaMLWritable): | |||
| """ | |||
| Evaluator for binary classification, which expects two input columns: rawPrediction and label. | |||
| Evaluator for binary classification, which expects input columns rawPrediction, label | |||
zhengruifeng
reviewed
Mar 3, 2020
| "(f1|accuracy|weightedPrecision|weightedRecall|weightedTruePositiveRate|" | ||
| "weightedFalsePositiveRate|weightedFMeasure|truePositiveRateByLabel|" | ||
| "falsePositiveRateByLabel|precisionByLabel|recallByLabel|fMeasureByLabel|" | ||
| "(f1|accuracy|weightedPrecision|weightedRecall|weightedTruePositiveRate| " |
There was a problem hiding this comment.
I guess we do not need to add spaces here
There was a problem hiding this comment.
Seems I have to break the line by adding a white space.
Before:
After:
srowen
approved these changes
Mar 3, 2020
| @@ -28,7 +28,8 @@ import org.apache.spark.sql.functions._ | |||
| import org.apache.spark.sql.types.DoubleType | |||
|
|
|||
| /** | |||
| * Evaluator for binary classification, which expects two input columns: rawPrediction and label. | |||
| * Evaluator for binary classification, which expects input columns rawPrediction, label and | |||
There was a problem hiding this comment.
Text is OK as is I think, but could quote the column names
huaxingao
changed the title
zhengruifeng
approved these changes
Mar 6, 2020
srowen
pushed a commit
that referenced
this pull request
Mar 7, 2020
### What changes were proposed in this pull request? Updating ML docs for 3.0 changes ### Why are the changes needed? I am auditing 3.0 ML changes, found some docs are missing or not updated. Need to update these. ### Does this PR introduce any user-facing change? Yes, doc changes ### How was this patch tested? Manually build and check Closes #27762 from huaxingao/spark-doc. Authored-by: Huaxin Gao <huaxing@us.ibm.com> Signed-off-by: Sean Owen <srowen@gmail.com> (cherry picked from commit 4a64901) Signed-off-by: Sean Owen <srowen@gmail.com>
|
Merged to master/3.0 |
|
Thank you very much! @srowen @zhengruifeng |
sjincho
pushed a commit
to sjincho/spark
that referenced
this pull request
Apr 15, 2020
### What changes were proposed in this pull request? Updating ML docs for 3.0 changes ### Why are the changes needed? I am auditing 3.0 ML changes, found some docs are missing or not updated. Need to update these. ### Does this PR introduce any user-facing change? Yes, doc changes ### How was this patch tested? Manually build and check Closes apache#27762 from huaxingao/spark-doc. Authored-by: Huaxin Gao <huaxing@us.ibm.com> Signed-off-by: Sean Owen <srowen@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Updating ML docs for 3.0 changes
Why are the changes needed?
I am auditing 3.0 ML changes, found some docs are missing or not updated. Need to update these.
Does this PR introduce any user-facing change?
Yes, doc changes
How was this patch tested?
Manually build and check