[SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable #27778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbtsai
changed the title
DataSourceStrategy.scala to minimize the changes to support nested predicate pushdown
...core/src/test/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategySuite.scala
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
Outdated
Show resolved
Hide resolved
dongjoon-hyun
approved these changes
Mar 3, 2020
rdblue
approved these changes
Mar 4, 2020
HyukjinKwon
reviewed
Mar 4, 2020
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
Outdated
Show resolved
Hide resolved
viirya
reviewed
Mar 4, 2020
...core/src/test/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategySuite.scala
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
HyukjinKwon
reviewed
Mar 4, 2020
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
Outdated
Show resolved
Hide resolved
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
Outdated
Show resolved
Hide resolved
|
@HyukjinKwon @dongjoon-hyun @viirya @rdblue @cloud-fan Some changes based on @HyukjinKwon 's suggestion to use extractor pattern have been done. Would like to have your final reviews. Thanks, |
HyukjinKwon
reviewed
Mar 4, 2020
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
Outdated
Show resolved
Hide resolved
HyukjinKwon
reviewed
Mar 4, 2020
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
retest this please |
cloud-fan
reviewed
Mar 4, 2020
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
Outdated
Show resolved
Hide resolved
cloud-fan
approved these changes
Mar 4, 2020
gengliangwang
approved these changes
Mar 4, 2020
This comment has been minimized.
This comment has been minimized.
|
Test build #119293 has finished for PR 27778 at commit
|
|
Merged to master. |
|
Thank you all. Looks much better! |
dbtsai
added a commit
that referenced
this pull request
Mar 4, 2020
### What changes were proposed in this pull request? Refactor `DataSourceStrategy.scala` and `DataSourceStrategySuite.scala` so it's more extendable to implement nested predicate pushdown. ### Why are the changes needed? To support nested predicate pushdown. ### Does this PR introduce any user-facing change? No. ### How was this patch tested? Existing tests and new tests. Closes #27778 from dbtsai/SPARK-31027. Authored-by: DB Tsai <d_tsai@apple.com> Signed-off-by: HyukjinKwon <gurwls223@apache.org>
|
Also merged into 3.0 branch since it's just refactoring without introducing new feature. It will make code maintenance easier for 3.0 and future master. Thanks all for reviewing. |
sjincho
pushed a commit
to sjincho/spark
that referenced
this pull request
Apr 15, 2020
### What changes were proposed in this pull request? Refactor `DataSourceStrategy.scala` and `DataSourceStrategySuite.scala` so it's more extendable to implement nested predicate pushdown. ### Why are the changes needed? To support nested predicate pushdown. ### Does this PR introduce any user-facing change? No. ### How was this patch tested? Existing tests and new tests. Closes apache#27778 from dbtsai/SPARK-31027. Authored-by: DB Tsai <d_tsai@apple.com> Signed-off-by: HyukjinKwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Refactor
DataSourceStrategy.scalaandDataSourceStrategySuite.scalaso it's more extendable to implement nested predicate pushdown.Why are the changes needed?
To support nested predicate pushdown.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing tests and new tests.