[SPARK-31138][ML][FOLLOWUP] ANOVA optimization #27979
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhengruifeng
commented
Mar 22, 2020
| val ssTot = sumOfSq - sqSum / numSamples | ||
| ).map { case (col, (sum, sumOfSq, sums, counts)) => | ||
| val numSamples = counts.iterator.map(_._2).sum | ||
| val numClasses = counts.size |
There was a problem hiding this comment.
directly get numSamples and numClasses here
|
Test build #120165 has finished for PR 27979 at commit
|
|
LGTM. Thanks @zhengruifeng |
|
Merged to master, thanks @srowen @huaxingao |
sjincho
pushed a commit
to sjincho/spark
that referenced
this pull request
Apr 15, 2020
### What changes were proposed in this pull request? 1, remove unused var `numFeatures`; 2, remove the computation of `numSamples` and `numClasses`, since they can be directly infered by `counts: OpenHashMap[Double, Long]` ### Why are the changes needed? remove a unnecessary job to compute `numSamples` and `numClasses` ### Does this PR introduce any user-facing change? No ### How was this patch tested? existing testsuites Closes apache#27979 from zhengruifeng/anova_followup. Authored-by: zhengruifeng <ruifengz@foxmail.com> Signed-off-by: zhengruifeng <ruifengz@foxmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
1, remove unused var
numFeatures;2, remove the computation of
numSamplesandnumClasses, since they can be directly infered bycounts: OpenHashMap[Double, Long]Why are the changes needed?
remove a unnecessary job to compute
numSamplesandnumClassesDoes this PR introduce any user-facing change?
No
How was this patch tested?
existing testsuites