[SPARK-31232][SQL][DOCS] Specify formats of spark.sql.session.timeZone
#27999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cloud-fan @HyukjinKwon Please, review this PR. |
cloud-fan
approved these changes
Mar 24, 2020
|
Test build #120258 has finished for PR 27999 at commit
|
|
jenkins, retest this, please |
|
Test build #120281 has finished for PR 27999 at commit
|
HyukjinKwon
approved these changes
Mar 25, 2020
HyukjinKwon
reviewed
Mar 25, 2020
| val SESSION_LOCAL_TIMEZONE = buildConf("spark.sql.session.timeZone") | ||
| .doc("The ID of session local timezone in the format of either region-based zone IDs or " + | ||
| "zone offsets. Region IDs must have the form 'area/city', such as 'America/Los_Angeles'. " + | ||
| "Zone offsets must be in the format '(+|-)HH:mm', for example '-08:00' or '+01:00'.") |
There was a problem hiding this comment.
Actually why don't we add the simple reason about three-latters timezones? Like you described in PR description: other formats such as three-letter timezone IDs are ambitious
|
Test build #120317 has finished for PR 27999 at commit
|
|
jenkins, retest this, please |
|
This is a doc only change, it should be good to go after pass compilation. Thanks, merging to master/3.0! |
cloud-fan
pushed a commit
that referenced
this pull request
Mar 25, 2020
In the PR, I propose to update the doc for `spark.sql.session.timeZone`, and restrict format of config's values to 2 forms: 1. Geographical regions, such as `America/Los_Angeles`. 2. Fixed offsets - a fully resolved offset from UTC. For example, `-08:00`. Other formats such as three-letter time zone IDs are ambitious, and depend on the locale. For example, `CST` could be U.S. `Central Standard Time` and `China Standard Time`. Such formats have been already deprecated in JDK, see [Three-letter time zone IDs](https://docs.oracle.com/javase/8/docs/api/java/util/TimeZone.html). No By running `./dev/scalastyle`, and manual testing. Closes #27999 from MaxGekk/doc-session-time-zone. Authored-by: Maxim Gekk <max.gekk@gmail.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com> (cherry picked from commit 27d53de) Signed-off-by: Wenchen Fan <wenchen@databricks.com>
|
Test build #120322 has finished for PR 27999 at commit
|
sjincho
pushed a commit
to sjincho/spark
that referenced
this pull request
Apr 15, 2020
### What changes were proposed in this pull request? In the PR, I propose to update the doc for `spark.sql.session.timeZone`, and restrict format of config's values to 2 forms: 1. Geographical regions, such as `America/Los_Angeles`. 2. Fixed offsets - a fully resolved offset from UTC. For example, `-08:00`. ### Why are the changes needed? Other formats such as three-letter time zone IDs are ambitious, and depend on the locale. For example, `CST` could be U.S. `Central Standard Time` and `China Standard Time`. Such formats have been already deprecated in JDK, see [Three-letter time zone IDs](https://docs.oracle.com/javase/8/docs/api/java/util/TimeZone.html). ### Does this PR introduce any user-facing change? No ### How was this patch tested? By running `./dev/scalastyle`, and manual testing. Closes apache#27999 from MaxGekk/doc-session-time-zone. Authored-by: Maxim Gekk <max.gekk@gmail.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In the PR, I propose to update the doc for
spark.sql.session.timeZone, and restrict format of config's values to 2 forms:America/Los_Angeles.-08:00.Why are the changes needed?
Other formats such as three-letter time zone IDs are ambitious, and depend on the locale. For example,
CSTcould be U.S.Central Standard TimeandChina Standard Time. Such formats have been already deprecated in JDK, see Three-letter time zone IDs.Does this PR introduce any user-facing change?
No
How was this patch tested?
By running
./dev/scalastyle, and manual testing.