[SPARK-31320] Fix release script for 3.0.0 #28088
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloud-fan
commented
Apr 1, 2020
| @@ -93,7 +93,7 @@ done | |||
|
|
|||
| GPG_KEY_FILE="$WORKDIR/gpg.key" | |||
| fcreate_secure "$GPG_KEY_FILE" | |||
| $GPG --export-secret-key --armor "$GPG_KEY" > "$GPG_KEY_FILE" | |||
| $GPG --export-secret-key --armor --pinentry-mode loopback --passphrase "$GPG_PASSPHRASE" "$GPG_KEY" > "$GPG_KEY_FILE" | |||
There was a problem hiding this comment.
the modern gpg command requires users to input a password, which breaks the workflow of the script. This fixes it.
cloud-fan
commented
Apr 1, 2020
| @@ -159,10 +159,14 @@ function get_release_info { | |||
| export SPARK_PACKAGE_VERSION="$RELEASE_TAG" | |||
|
|
|||
| # Gather some user information. | |||
| export ASF_USERNAME=$(read_config "ASF user" "$LOGNAME") | |||
| if [ -z "$ASF_USERNAME" ]; then | |||
There was a problem hiding this comment.
we should respect these env variables if they exist
cloud-fan
commented
Apr 1, 2020
| ARG BASE_PIP_PKGS="setuptools wheel" | ||
| ARG PIP_PKGS="pyopenssl numpy sphinx" | ||
| ARG PIP_PKGS="sphinx==2.3.1 mkdocs==1.0.4 numpy==1.18.1" | ||
| ARG GEM_PKGS="jekyll:4.0.0 jekyll-redirect-from:0.16.0 rouge:3.15.0" |
There was a problem hiding this comment.
This follows part of #27534
|
Note that we should forward port this to the master branch. It was done at |
HyukjinKwon
changed the title
HyukjinKwon
approved these changes
Apr 1, 2020
| gem install jekyll --no-rdoc --no-ri -v 3.8.6 && \ | ||
| gem install jekyll-redirect-from -v 0.15.0 && \ | ||
| gem install rouge | ||
| $APT_INSTALL ruby2.5 ruby2.5-dev && \ |
There was a problem hiding this comment.
So, did ruby2.5 work correctly?
There was a problem hiding this comment.
mkdocs requires ruby 2.4+, I googled a bit and seems ubuntu 18 supports ruby 2.5 at most.
|
cc @rxin and @gatorsmile |
|
Test build #120663 has finished for PR 28088 at commit
|
HyukjinKwon
pushed a commit
that referenced
this pull request
Apr 1, 2020
### What changes were proposed in this pull request? The release script stops working after d586549 , as we require `mkdocs 1.0.0`. This PR upgrades `mkdocs` from 0.1.6.3 to 1.0.4. To do that ruby is also upgraded to 2.5. This PR also fixes some small issues. ### Why are the changes needed? to make RC ### Does this PR introduce any user-facing change? no ### How was this patch tested? tested by 3.0.0-rc1 Closes #28088 from cloud-fan/rc. Authored-by: Wenchen Fan <wenchen@databricks.com> Signed-off-by: HyukjinKwon <gurwls223@apache.org>
|
Merged to master and branch-3.0. |
sjincho
pushed a commit
to sjincho/spark
that referenced
this pull request
Apr 15, 2020
### What changes were proposed in this pull request? The release script stops working after apache@d586549 , as we require `mkdocs 1.0.0`. This PR upgrades `mkdocs` from 0.1.6.3 to 1.0.4. To do that ruby is also upgraded to 2.5. This PR also fixes some small issues. ### Why are the changes needed? to make RC ### Does this PR introduce any user-facing change? no ### How was this patch tested? tested by 3.0.0-rc1 Closes apache#28088 from cloud-fan/rc. Authored-by: Wenchen Fan <wenchen@databricks.com> Signed-off-by: HyukjinKwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The release script stops working after d586549 , as we require
mkdocs 1.0.0.This PR upgrades
mkdocsfrom 0.1.6.3 to 1.0.4. To do that ruby is also upgraded to 2.5.This PR also fixes some small issues.
Why are the changes needed?
to make RC
Does this PR introduce any user-facing change?
no
How was this patch tested?
tested by 3.0.0-rc1