[SPARK-31010][SQL][DOC][FOLLOW-UP] Improve deprecated warning message for untyped scala udf #28311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ngone51
changed the title
Ngone51
changed the title
|
Test build #121665 has started for PR 28311 at commit |
Ngone51
commented
Apr 23, 2020
cloud-fan
reviewed
Apr 23, 2020
srowen
approved these changes
Apr 23, 2020
|
Test build #121667 has finished for PR 28311 at commit
|
|
Test build #121680 has finished for PR 28311 at commit
|
HyukjinKwon
reviewed
Apr 24, 2020
cloud-fan
reviewed
Apr 24, 2020
|
Test build #121711 has finished for PR 28311 at commit
|
|
Test build #121716 has finished for PR 28311 at commit
|
|
retest this please |
cloud-fan
approved these changes
Apr 24, 2020
|
Let me just merge this since the related checks such as build and linter passed. |
|
Merged to master and branch-3.0. |
HyukjinKwon
pushed a commit
that referenced
this pull request
Apr 24, 2020
… for untyped scala udf ### What changes were proposed in this pull request? Give more friendly warning message/migration guide of deprecated scala udf to users. ### Why are the changes needed? User can not distinguish function signature between typed and untyped scala udf. Instead, we shall tell user what to do directly. ### Does this PR introduce any user-facing change? No, it's newly added in Spark 3.0. ### How was this patch tested? Pass Jenkins. Closes #28311 from Ngone51/update_udf_doc. Authored-by: yi.wu <yi.wu@databricks.com> Signed-off-by: HyukjinKwon <gurwls223@apache.org> (cherry picked from commit 463c544) Signed-off-by: HyukjinKwon <gurwls223@apache.org>
|
Test build #121736 has finished for PR 28311 at commit
|
|
thanks all!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Give more friendly warning message/migration guide of deprecated scala udf to users.
Why are the changes needed?
User can not distinguish function signature between typed and untyped scala udf. Instead, we shall tell user what to do directly.
Does this PR introduce any user-facing change?
No, it's newly added in Spark 3.0.
How was this patch tested?
Pass Jenkins.