[SPARK-31550][SQL][DOCS] Set nondeterministic configurations with general meanings in sql configuration doc #28322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eral meanings in sql configuration doc
|
Test build #121721 has finished for PR 28322 at commit
|
|
Jenkins, retest this please |
|
Test build #121729 has finished for PR 28322 at commit
|
|
retest this please |
|
Test build #121750 has finished for PR 28322 at commit
|
|
cc: @dongjoon-hyun @cloud-fan @maropu too, thanks. |
maropu
reviewed
Apr 25, 2020
sql/core/src/main/scala/org/apache/spark/sql/api/python/PythonSQLUtils.scala
Outdated
Show resolved
Hide resolved
maropu
reviewed
Apr 25, 2020
maropu
reviewed
Apr 25, 2020
sql/core/src/main/scala/org/apache/spark/sql/api/python/PythonSQLUtils.scala
Outdated
Show resolved
Hide resolved
|
Test build #121800 has finished for PR 28322 at commit
|
HyukjinKwon
reviewed
Apr 26, 2020
sql/core/src/main/scala/org/apache/spark/sql/api/python/PythonSQLUtils.scala
Outdated
Show resolved
Hide resolved
|
Test build #121830 has finished for PR 28322 at commit
|
|
Test build #121843 has finished for PR 28322 at commit
|
HyukjinKwon
approved these changes
Apr 27, 2020
|
Merged to master and branch-3.0. |
HyukjinKwon
pushed a commit
that referenced
this pull request
Apr 27, 2020
…eral meanings in sql configuration doc ### What changes were proposed in this pull request? ```scala spark.sql.session.timeZone spark.sql.warehouse.dir ``` these 2 configs are nondeterministic and vary with environments Besides, reflect code in `gen-sql-config-docs.py` via #28274 (comment) and `configuration.md` via #28274 (comment) ### Why are the changes needed? doc fix ### Does this PR introduce any user-facing change? no ### How was this patch tested? verify locally  Closes #28322 from yaooqinn/SPARK-31550. Authored-by: Kent Yao <yaooqinn@hotmail.com> Signed-off-by: HyukjinKwon <gurwls223@apache.org> (cherry picked from commit 5ba467c) Signed-off-by: HyukjinKwon <gurwls223@apache.org>
|
late LGTM, thanks for the update, @yaooqinn |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
these 2 configs are nondeterministic and vary with environments
Besides, reflect code in
gen-sql-config-docs.pyvia #28274 (comment) andconfiguration.mdvia #28274 (comment)Why are the changes needed?
doc fix
Does this PR introduce any user-facing change?
no
How was this patch tested?
verify locally
