Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-31659][ML][DOCS] Add VarianceThresholdSelector examples and doc #28478

Closed
wants to merge 2 commits into from

Conversation

huaxingao
Copy link
Contributor

What changes were proposed in this pull request?

Add VarianceThresholdSelector examples and doc

Why are the changes needed?

VarianceThresholdSelector is a new feature selector in 3.1.0. We need to add examples and doc

Does this PR introduce any user-facing change?

Yes.
add Scala, Python and Java examples for VarianceThresholdSelector. Also add doc

Screen Shot 2020-05-07 at 9 20 01 AM

Screen Shot 2020-05-07 at 9 20 44 AM

Screen Shot 2020-05-07 at 9 21 27 AM

Screen Shot 2020-05-07 at 9 21 43 AM

How was this patch tested?

Manually checked

@SparkQA
Copy link

SparkQA commented May 7, 2020

Test build #122410 has finished for PR 28478 at commit 8d7903a.

  • This patch fails Java style tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
  • public class JavaVarianceThresholdSelectorExample

@SparkQA
Copy link

SparkQA commented May 7, 2020

Test build #122411 has finished for PR 28478 at commit 87bf379.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@huaxingao
Copy link
Contributor Author

cc @srowen @zhengruifeng

Copy link
Member

@srowen srowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems OK.

@zhengruifeng
Copy link
Contributor

Merged to master

@huaxingao
Copy link
Contributor Author

Thanks! @srowen @zhengruifeng

@huaxingao huaxingao deleted the variance_doc branch May 8, 2020 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants