-
Notifications
You must be signed in to change notification settings - Fork 28.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-31620][SQL] Fix reference binding failure in case of an final agg contains subquery #28496
Changes from all commits
ba75e36
4dcc1b1
bc1b7e5
cbd891d
882467b
9a0b788
3fd39c5
64d13fc
89ae4bf
8aecd57
493157a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -123,7 +123,7 @@ case class ObjectHashAggregateExec( | |
resultExpressions, | ||
(expressions, inputSchema) => | ||
MutableProjection.create(expressions, inputSchema), | ||
child.output, | ||
inputAttributes, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There's actually another There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You can open a new PR to remove dead code There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ok.. |
||
iter, | ||
fallbackCountThreshold, | ||
numOutputRows) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I try to fix like this before, but I forgot to change child's output here then output column can't work well.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your confirm.