Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-31708][ML][DOCS] Add docs and examples for ANOVASelector and FValueSelector #28524

Closed
wants to merge 1 commit into from

Conversation

huaxingao
Copy link
Contributor

What changes were proposed in this pull request?

Add docs and examples for ANOVASelector and FValueSelector

Why are the changes needed?

Complete the implementation of ANOVASelector and FValueSelector

Does this PR introduce any user-facing change?

Yes

Screen Shot 2020-05-13 at 5 17 44 PM

Screen Shot 2020-05-13 at 5 05 15 PM

Screen Shot 2020-05-13 at 5 06 06 PM

Screen Shot 2020-05-13 at 5 06 21 PM

Screen Shot 2020-05-13 at 5 07 10 PM

Screen Shot 2020-05-13 at 5 07 33 PM

Screen Shot 2020-05-13 at 5 07 47 PM

Screen Shot 2020-05-13 at 5 19 35 PM

Screen Shot 2020-05-13 at 5 08 42 PM

Screen Shot 2020-05-13 at 5 09 01 PM

Screen Shot 2020-05-13 at 5 09 50 PM

Screen Shot 2020-05-13 at 5 10 06 PM

Screen Shot 2020-05-13 at 5 10 59 PM

Screen Shot 2020-05-13 at 5 11 27 PM

Screen Shot 2020-05-13 at 5 14 54 PM

Screen Shot 2020-05-13 at 5 15 17 PM

How was this patch tested?

Manually build and check

@@ -51,7 +51,7 @@ public static void main(String[] args) {
List<Row> data = Arrays.asList(
RowFactory.create(3.0, Vectors.dense(1.7, 4.4, 7.6, 5.8, 9.6, 2.3)),
RowFactory.create(2.0, Vectors.dense(8.8, 7.3, 5.7, 7.3, 2.2, 4.1)),
RowFactory.create(1.0, Vectors.dense(1.2, 9.5, 2.5, 3.1, 8.7, 2.5)),
RowFactory.create(3.0, Vectors.dense(1.2, 9.5, 2.5, 3.1, 8.7, 2.5)),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it's not a good example to have only one data in a category. I changed 1.0 -> 3.0, so there are two data in each of the category.

@SparkQA
Copy link

SparkQA commented May 14, 2020

Test build #122601 has finished for PR 28524 at commit 76edc3d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Member

@srowen srowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remind me, this is just for 3.1?

@huaxingao
Copy link
Contributor Author

@srowen Yes, it's only for 3.1. Thanks!

@srowen srowen closed this in 194ac3b May 15, 2020
@srowen
Copy link
Member

srowen commented May 15, 2020

Merged to master

@huaxingao
Copy link
Contributor Author

Thanks! @srowen @zhengruifeng

@huaxingao huaxingao deleted the examples branch May 15, 2020 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants