[SPARK-31719][SQL] Refactor JoinSelection

[dbaliafroozeh]

What changes were proposed in this pull request?

This PR extracts the logic for selecting the planned join type out of the JoinSelection rule and moves it to JoinSelectionHelper in Catalyst.

Why are the changes needed?

This change both cleans up the code in JoinSelection and allows the logic to be in one place and be used from other rules that need to make decision based on the join type before the planning time.

Does this PR introduce any user-facing change?

BuildSide, BuildLeft, and BuildRight are moved from org.apache.spark.sql.execution to Catalyst in org.apache.spark.sql.catalyst.optimizer.

How was this patch tested?

This is a refactoring, passes existing tests.

[hvanhovell]

ok to test

[hvanhovell]

add to whitelist

[SparkQA]

Test build #122670 has finished for PR 28540 at commit 0b22913.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[SparkQA]

Test build #122810 has finished for PR 28540 at commit 9db3a91.

• This patch fails Spark unit tests.
• This patch merges cleanly.
• This patch adds no public classes.

[SparkQA]

Test build #122816 has finished for PR 28540 at commit 42f3a29.

• This patch fails PySpark unit tests.
• This patch merges cleanly.
• This patch adds no public classes.

[SparkQA]

Test build #122809 has finished for PR 28540 at commit a8f4e0b.

• This patch fails from timeout after a configured wait of 400m.
• This patch merges cleanly.
• This patch adds no public classes.

[maropu]

retest this please

[SparkQA]

Test build #122820 has finished for PR 28540 at commit 8a2d0ee.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[SparkQA]

Test build #122821 has finished for PR 28540 at commit 8a2d0ee.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[SparkQA]

Test build #122843 has finished for PR 28540 at commit 10da76a.

• This patch fails from timeout after a configured wait of 400m.
• This patch merges cleanly.
• This patch adds no public classes.

[SparkQA]

Test build #122901 has finished for PR 28540 at commit 8b30d51.

• This patch fails Spark unit tests.
• This patch merges cleanly.
• This patch adds no public classes.

[dbaliafroozeh]

retest this please

[SparkQA]

Test build #123064 has finished for PR 28540 at commit f94fbd3.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[maropu]

nit: selectOnlyFromHint? I couldn't tell what this meant just by the name onlyLookingAtHint .

[cloud-fan]

If we want to be super clear, maybe "pickJoinSideByHintOnly"? or simply "hintOnly".

[maropu]

Ah, hintOnly looks nice to me.

[maropu]

LGTM if the tests passed.

[SparkQA]

Test build #123185 has finished for PR 28540 at commit b455b12.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds the following public classes (experimental):
• class JoinSelectionHelperSuite extends PlanTest with JoinSelectionHelper

[cloud-fan]

thanks, merging to master!

[cloud-fan]

oops, the latest commit hasn't passed tests yet. I'll monitor the jenkins status.

[SparkQA]

Test build #123190 has finished for PR 28540 at commit 8fbe29c.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.