-
Notifications
You must be signed in to change notification settings - Fork 28.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert [SPARK-27142][SPARK-31440] SQL rest API in branch 3.0 #28588
Conversation
cc @erenavsarogullari @ajithme as well |
agree. Its better to revert and we can reraise the PR on later release. will 3.x be a candidate for these PRs.? |
@ajithme thanks for understanding! The commits are still in the master branch and they will be 3.1 as well. |
It's unfortunate that we find problems in SQL REST API at this stage which is too late to change. LGTM to revert it from 3.0 and release it in 3.1. |
Hi @gengliangwang, |
merging to 3.0 |
@gengliangwang test is still running |
+1 from my side too. |
@HyukjinKwon oh thanks for reminder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Test build #122871 has finished for PR 28588 at commit
|
retest this please. |
Test build #122876 has finished for PR 28588 at commit
|
thanks, merging to 3.0! |
### What changes were proposed in this pull request? Revert #28208 and #24076 in branch 3.0 ### Why are the changes needed? Unfortunately, the PR #28208 is merged after Spark 3.0 RC 2 cut. Although the improvement is great, we can't break the policy to add new improvement commits into branch 3.0 now. Also, if we are going to adopt the improvement in a future release, we should not release 3.0 with #24076, since the API result will be changed. After discuss with cloud-fan and gatorsmile offline, we think the best choice is to revert both commits and follow community release policy. ### Does this PR introduce _any_ user-facing change? Yes, let's hold the SQL rest API until next release. ### How was this patch tested? Jenkins unit tests. Closes #28588 from gengliangwang/revertSQLRestAPI. Authored-by: Gengliang Wang <gengliang.wang@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
What changes were proposed in this pull request?
Revert #28208 and #24076 in branch 3.0
Why are the changes needed?
Unfortunately, the PR #28208 is merged after Spark 3.0 RC 2 cut. Although the improvement is great, we can't break the policy to add new improvement commits into branch 3.0 now.
Also, if we are going to adopt the improvement in a future release, we should not release 3.0 with #24076, since the API result will be changed.
After discuss with @cloud-fan and @gatorsmile offline, we think the best choice is to revert both commits and follow community release policy.
Does this PR introduce any user-facing change?
Yes, let's hold the SQL rest API until next release.
How was this patch tested?
Jenkins unit tests.