[SPARK-31840][ML] Add instance weight support in LogisticRegressionSummary #28657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huaxingao
force-pushed
the
weighted_summary
branch
from
8ac2f3e
to
b0f7bcc
Compare
|
Test build #123196 has finished for PR 28657 at commit
|
|
Test build #123197 has finished for PR 28657 at commit
|
|
Test build #123198 has finished for PR 28657 at commit
|
srowen
approved these changes
May 29, 2020
|
|
||
| //[SPARK-31840] Add instance weight support in LogisticRegressionSummary | ||
| // weightCol in org.apache.spark.ml.classification.LogisticRegressionSummary is present only in current version | ||
| ProblemFilters.exclude[ReversedMissingMethodProblem]("org.apache.spark.ml.classification.LogisticRegressionSummary.weightCol") |
There was a problem hiding this comment.
Looks fine, that's a sealed trait anyway
|
Merged to master |
|
@srowen Thanks Sean! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add instance weight support in LogisticRegressionSummary
Why are the changes needed?
LogisticRegression, MulticlassClassificationEvaluator and BinaryClassificationEvaluator support instance weight. We should support instance weight in LogisticRegressionSummary too.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Add new tests