[SPARK-28624][SQL][TESTS] Run date.sql via Thrift Server #28721
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #123508 has finished for PR 28721 at commit
|
|
retest this please |
|
Looks nice if the tests passed. |
|
Test build #123512 has finished for PR 28721 at commit
|
maropu
approved these changes
Jun 4, 2020
|
This fix can be merged into branch-3.0? I'm not really sure that |
|
Let me merge it to master first. From reading the JIRA, seems it's fixed only in the master. |
|
Merged to master. |
holdenk
pushed a commit
to holdenk/spark
that referenced
this pull request
Jun 4, 2020
### What changes were proposed in this pull request? Enable `date.sql` and run it via Thrift Server in `ThriftServerQueryTestSuite`. ### Why are the changes needed? To improve test coverage. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? By running the enabled tests via: ``` $ build/sbt -Phive-thriftserver "hive-thriftserver/test-only *ThriftServerQueryTestSuite -- -z date.sql" ``` Closes apache#28721 from MaxGekk/enable-date.sql-for-thrift. Authored-by: Max Gekk <max.gekk@gmail.com> Signed-off-by: HyukjinKwon <gurwls223@apache.org>
|
I had an offline discussion with @MaxGekk and @cloud-fan. Per #28723 (comment), I will revert this too. Again, technically it was fine to merge in a way because the skipped tests passed. I am here reverting this rather for the management purpose - the JIRA isn't resolved yet because we need to discuss if the result is correct or not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Enable
date.sqland run it via Thrift Server inThriftServerQueryTestSuite.Why are the changes needed?
To improve test coverage.
Does this PR introduce any user-facing change?
No
How was this patch tested?
By running the enabled tests via: