-
Notifications
You must be signed in to change notification settings - Fork 28.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-31967][UI] Downgrade to vis.js 4.21.0 to fix Jobs UI loading time regression #28806
Conversation
I didn't find vis-timeline-graph2d.min.css.map and vis-timeline-graph2d.min.js.map in https://cdnjs.com/libraries/vis, so I deleted them. It should be minor. |
I can't download the downgraded version of |
@sarutak it works fine in my side: |
I can't still get from the URL but can get from https://almende.github.io/vis/ anyway. |
OK, the 4.21.0 package in https://almende.github.io/vis/ should be the same |
@gengliangwang I checked out the change and build but timeline-view wouldn't work. I also tried replacing the library with the one from https://almende.github.io/vis/ and works. |
Test build #123889 has finished for PR 28806 at commit
|
@sarutak ok I have replaced with the one from https://almende.github.io/vis/ |
Actually that is not fixed in 4.21.0. Maybe, we compromise either infinite redrawing issue or this performance issue... |
well, in my setup, if the "Enable zooming" checkbox is not clicked, the infinite redrawing won't happen.
yeah, I prefer infinite redrawing to the 40 seconds perf issue ... |
LGTM. |
Test build #123900 has finished for PR 28806 at commit
|
@gengliangwang Do you want to wait for other reviews? |
Just for the record - this is a downgrade, upgrade? |
@srowen it's downgrade |
I am going to merge this one, and backport it to 3.0 / 2.4 |
Hi, @gengliangwang and @sarutak . I'm wondering if this is safer enough than reverting SPARK-31420. Are we sure that there is no more UI regressions? It's difficult to detect manually this kind of slowness regression. cc @rxin and @holdenk since they are the recent release managers. |
@dongjoon-hyun the PR #28192 is to fix the infinite timeline redraw bug in https://issues.apache.org/jira/browse/SPARK-31420 . The bug will happen again if we simply reverting #28192 . This downgraded solution is better. In my local setup, the perf issue can't not be reproduced, and by default the infinite timeline redrawing won't happen unless the "Enable zooming" checkbox. I believe this is a better solution. |
Talked to @dongjoon-hyun offline. He is ok to merge this now |
Merging to master. |
Downgrading |
What changes were proposed in this pull request?
After #28192, the job list page becomes very slow.
For example, after the following operation, the UI loading can take >40 sec.
This is caused by a performance issue of
vis-timeline
. The serious issue affects both branch-3.0 and branch-2.4I tried a different version 4.21.0 from https://cdnjs.com/libraries/vis
The infinite drawing issue seems also fixed if the zoom is disabled as default.
Why are the changes needed?
Fix the serious perf issue in web UI by falling back vis-timeline-graph2d to an ealier version.
Does this PR introduce any user-facing change?
Yes, fix the UI perf regression
How was this patch tested?
Manual test