Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-29148][CORE][FOLLOWUP] Fix warning message to show a correct executor id #28847

Closed
wants to merge 1 commit into from
Closed

[SPARK-29148][CORE][FOLLOWUP] Fix warning message to show a correct executor id #28847

wants to merge 1 commit into from

Conversation

dongjoon-hyun
Copy link
Member

What changes were proposed in this pull request?

This aims to replace executorIdsToBeRemoved with executorIdToBeRemoved.

Why are the changes needed?

Since a wrong variable is used currently, ArrayBuffer() is always displayed.

20/06/16 19:33:31 WARN ExecutorAllocationManager: Not removing executor ArrayBuffer() because the ResourceProfile was UNKNOWN!

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Manual.

@dongjoon-hyun
Copy link
Member Author

cc @tgravescs

@dongjoon-hyun
Copy link
Member Author

Thank you, @HyukjinKwon .

@dongjoon-hyun
Copy link
Member Author

Merged to master.

@dongjoon-hyun dongjoon-hyun deleted the SPARK-29148 branch June 17, 2020 04:05
@SparkQA
Copy link

SparkQA commented Jun 17, 2020

Test build #124151 has finished for PR 28847 at commit c195a7f.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@tgravescs
Copy link
Contributor

thanks for fixing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HyukjinKwon HyukjinKwon HyukjinKwon approved these changes

Assignees
No one assigned
Labels
CORE
Projects
None yet
Milestone
No milestone
4 participants
@dongjoon-hyun @SparkQA @tgravescs @HyukjinKwon