Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-19939] [ML] Add support for association rules in ML #28903

Closed
wants to merge 2 commits into from

Conversation

huaxingao
Copy link
Contributor

What changes were proposed in this pull request?

Adding support to Association Rules in Spark ml.fpm.

Why are the changes needed?

Support is an indication of how frequently the itemset of an association rule appears in the database and suggests if the rules are generally applicable to the dateset. Refer to wiki for more details.

Does this PR introduce any user-facing change?

Yes. Associate Rules now have support measure

How was this patch tested?

existing and new unit test

@SparkQA
Copy link

SparkQA commented Jun 23, 2020

Test build #124392 has finished for PR 28903 at commit 1cc6560.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds no public classes.

@huaxingao
Copy link
Contributor Author

retest this please

@SparkQA
Copy link

SparkQA commented Jun 23, 2020

Test build #124399 has finished for PR 28903 at commit 1cc6560.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@huaxingao
Copy link
Contributor Author

cc @srowen @zhengruifeng

@srowen
Copy link
Member

srowen commented Jun 24, 2020

I was going to say, can't a caller just compute this if desired? but I guess freqUnion isn't exposed?
If it's a simple addition to the returned DataFrame to expose it and it isn't otherwise available, I could see it.

@zhengruifeng
Copy link
Contributor

Does it means that the support is computed in the .mllib side but not exposed in the .ml side?

@huaxingao
Copy link
Contributor Author

freqUnion is computed in mllib side but not exposed.

@SparkQA
Copy link

SparkQA commented Jun 24, 2020

Test build #124452 has finished for PR 28903 at commit c80ec10.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member

srowen commented Jun 26, 2020

Merged to master

@srowen srowen closed this in d125529 Jun 26, 2020
@huaxingao
Copy link
Contributor Author

Thanks! @srowen @zhengruifeng

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants