Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

specify unidocGenjavadocVersion of 0.8 #2893

Closed
wants to merge 1 commit into from
Closed

specify unidocGenjavadocVersion of 0.8 #2893

wants to merge 1 commit into from

Conversation

holdenk
Copy link
Contributor

@holdenk holdenk commented Oct 22, 2014

Fixes an issue with being too strict generating javadoc causing errors.

@SparkQA
Copy link

SparkQA commented Oct 22, 2014

QA tests have started for PR 2893 at commit 9379a70.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Oct 22, 2014

QA tests have finished for PR 2893 at commit 9379a70.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/22037/
Test PASSed.

@srowen
Copy link
Member

srowen commented Oct 23, 2014

This is for SPARK-3359. LGTM, thank you. This gets past some errors, and turns up more, which I'll comment on in the JIRA. But this is a step forward.

@srowen srowen mentioned this pull request Oct 23, 2014
Closed
@mengxr
Copy link
Contributor

mengxr commented Oct 23, 2014

Verified that this change doesn't affect unidoc with Java 6 and 7. Merged into master. Thanks!

@asfgit asfgit closed this in 293672c Oct 23, 2014
asfgit pushed a commit that referenced this pull request Oct 26, 2014
@srowen @mengxr
SPARK-3359 [DOCS] sbt/sbt unidoc doesn't work with Java 8
df7974b 
This follows #2893 , but does not completely fix SPARK-3359 either. This fixes minor scaladoc/javadoc issues that Javadoc 8 will treat as errors.

Author: Sean Owen <sowen@cloudera.com>

Closes #2909 from srowen/SPARK-3359 and squashes the following commits:

f62c347 [Sean Owen] Fix some javadoc issues that javadoc 8 considers errors. This is not all of the errors turned up when javadoc 8 runs on output of genjavadoc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@holdenk @SparkQA @AmplabJenkins @srowen @mengxr