Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-32024][WEBUI][FOLLOWUP][3.0] Quick fix on test failure on missing when statements #29047

Conversation

HeartSaVioR
Copy link
Contributor

What changes were proposed in this pull request?

This patch fixes the test failure due to the missing when statements for destination path. Note that it didn't fail on master branch, because 245aee9 got rid of size call in destination path, but still good to not depend on 245aee9.

Why are the changes needed?

The build against branch-3.0 / branch-2.4 starts to fail after merging SPARK-32024 (#28859) and this patch will fix it.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Ran modified UT against master / branch-3.0 / branch-2.4.

@HeartSaVioR
Copy link
Contributor Author

@dongjoon-hyun
Copy link
Member

Thank you!

@SparkQA
Copy link

SparkQA commented Jul 9, 2020

Test build #125414 has finished for PR 29047 at commit 6a36c9c.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member

There was no conflict. I just merged #29046 through.

@HyukjinKwon HyukjinKwon closed this Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants