[SPARK-32245][INFRA][FOLLOWUP] Reenable Github Actions on commit #29076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @HyukjinKwon , @gengliangwang , @viirya . As a next step, I want to enable this back and see the traffic. |
viirya
reviewed
Jul 12, 2020
Comment on lines
+4
to
+6
| push: | ||
| branches: | ||
| - master |
There was a problem hiding this comment.
For Github Actions running for push event, where I can look at the action logs? Still in "Check" tab of PRs? When will it be triggered? Merging?
There was a problem hiding this comment.
We can see at two places.
- At commit log. At every commit log, the green check mark is attached.
- At commit info,
Currently, it's disabled yesterday. So, recent commits do not have that.
|
Test build #125721 has finished for PR 29076 at commit
|
viirya
approved these changes
Jul 12, 2020
|
Yes. Right. Thanks, @viirya . |
HyukjinKwon
reviewed
Jul 12, 2020
HyukjinKwon
pushed a commit
to HyukjinKwon/spark
that referenced
this pull request
Aug 18, 2020
This PR reenables GitHub Action on every commit as a next step. We carefully enabled GitHub Action on every PRs, and it looks good so far. As we saw at apache#29072, GitHub Action is already triggered at every commits on every PRs. Enabling GitHub Action on `master` branch commit doesn't make a big difference. And, we need to start to test at every commit as a next step. No. Manual. Closes apache#29076 from dongjoon-hyun/reenable_gha_commit. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
HyukjinKwon
pushed a commit
to HyukjinKwon/spark
that referenced
this pull request
Aug 18, 2020
This PR reenables GitHub Action on every commit as a next step. We carefully enabled GitHub Action on every PRs, and it looks good so far. As we saw at apache#29072, GitHub Action is already triggered at every commits on every PRs. Enabling GitHub Action on `master` branch commit doesn't make a big difference. And, we need to start to test at every commit as a next step. No. Manual. Closes apache#29076 from dongjoon-hyun/reenable_gha_commit. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
HyukjinKwon
pushed a commit
to HyukjinKwon/spark
that referenced
this pull request
Aug 18, 2020
This PR reenables GitHub Action on every commit as a next step. We carefully enabled GitHub Action on every PRs, and it looks good so far. As we saw at apache#29072, GitHub Action is already triggered at every commits on every PRs. Enabling GitHub Action on `master` branch commit doesn't make a big difference. And, we need to start to test at every commit as a next step. No. Manual. Closes apache#29076 from dongjoon-hyun/reenable_gha_commit. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
HyukjinKwon
pushed a commit
to HyukjinKwon/spark
that referenced
this pull request
Aug 18, 2020
This PR reenables GitHub Action on every commit as a next step. We carefully enabled GitHub Action on every PRs, and it looks good so far. As we saw at apache#29072, GitHub Action is already triggered at every commits on every PRs. Enabling GitHub Action on `master` branch commit doesn't make a big difference. And, we need to start to test at every commit as a next step. No. Manual. Closes apache#29076 from dongjoon-hyun/reenable_gha_commit. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
HyukjinKwon
pushed a commit
to HyukjinKwon/spark
that referenced
this pull request
Aug 18, 2020
This PR reenables GitHub Action on every commit as a next step. We carefully enabled GitHub Action on every PRs, and it looks good so far. As we saw at apache#29072, GitHub Action is already triggered at every commits on every PRs. Enabling GitHub Action on `master` branch commit doesn't make a big difference. And, we need to start to test at every commit as a next step. No. Manual. Closes apache#29076 from dongjoon-hyun/reenable_gha_commit. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
HyukjinKwon
pushed a commit
to HyukjinKwon/spark
that referenced
this pull request
Aug 18, 2020
This PR reenables GitHub Action on every commit as a next step. We carefully enabled GitHub Action on every PRs, and it looks good so far. As we saw at apache#29072, GitHub Action is already triggered at every commits on every PRs. Enabling GitHub Action on `master` branch commit doesn't make a big difference. And, we need to start to test at every commit as a next step. No. Manual. Closes apache#29076 from dongjoon-hyun/reenable_gha_commit. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
HyukjinKwon
pushed a commit
to HyukjinKwon/spark
that referenced
this pull request
Aug 18, 2020
This PR reenables GitHub Action on every commit as a next step. We carefully enabled GitHub Action on every PRs, and it looks good so far. As we saw at apache#29072, GitHub Action is already triggered at every commits on every PRs. Enabling GitHub Action on `master` branch commit doesn't make a big difference. And, we need to start to test at every commit as a next step. No. Manual. Closes apache#29076 from dongjoon-hyun/reenable_gha_commit. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
HyukjinKwon
pushed a commit
to HyukjinKwon/spark
that referenced
this pull request
Aug 18, 2020
This PR reenables GitHub Action on every commit as a next step. We carefully enabled GitHub Action on every PRs, and it looks good so far. As we saw at apache#29072, GitHub Action is already triggered at every commits on every PRs. Enabling GitHub Action on `master` branch commit doesn't make a big difference. And, we need to start to test at every commit as a next step. No. Manual. Closes apache#29076 from dongjoon-hyun/reenable_gha_commit. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
HyukjinKwon
pushed a commit
to HyukjinKwon/spark
that referenced
this pull request
Aug 18, 2020
This PR reenables GitHub Action on every commit as a next step. We carefully enabled GitHub Action on every PRs, and it looks good so far. As we saw at apache#29072, GitHub Action is already triggered at every commits on every PRs. Enabling GitHub Action on `master` branch commit doesn't make a big difference. And, we need to start to test at every commit as a next step. No. Manual. Closes apache#29076 from dongjoon-hyun/reenable_gha_commit. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
HyukjinKwon
pushed a commit
to HyukjinKwon/spark
that referenced
this pull request
Aug 18, 2020
This PR reenables GitHub Action on every commit as a next step. We carefully enabled GitHub Action on every PRs, and it looks good so far. As we saw at apache#29072, GitHub Action is already triggered at every commits on every PRs. Enabling GitHub Action on `master` branch commit doesn't make a big difference. And, we need to start to test at every commit as a next step. No. Manual. Closes apache#29076 from dongjoon-hyun/reenable_gha_commit. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
HyukjinKwon
pushed a commit
to HyukjinKwon/spark
that referenced
this pull request
Aug 18, 2020
This PR reenables GitHub Action on every commit as a next step. We carefully enabled GitHub Action on every PRs, and it looks good so far. As we saw at apache#29072, GitHub Action is already triggered at every commits on every PRs. Enabling GitHub Action on `master` branch commit doesn't make a big difference. And, we need to start to test at every commit as a next step. No. Manual. Closes apache#29076 from dongjoon-hyun/reenable_gha_commit. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
HyukjinKwon
pushed a commit
to HyukjinKwon/spark
that referenced
this pull request
Aug 19, 2020
This PR reenables GitHub Action on every commit as a next step. We carefully enabled GitHub Action on every PRs, and it looks good so far. As we saw at apache#29072, GitHub Action is already triggered at every commits on every PRs. Enabling GitHub Action on `master` branch commit doesn't make a big difference. And, we need to start to test at every commit as a next step. No. Manual. Closes apache#29076 from dongjoon-hyun/reenable_gha_commit. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
HyukjinKwon
pushed a commit
to HyukjinKwon/spark
that referenced
this pull request
Aug 19, 2020
This PR reenables GitHub Action on every commit as a next step. We carefully enabled GitHub Action on every PRs, and it looks good so far. As we saw at apache#29072, GitHub Action is already triggered at every commits on every PRs. Enabling GitHub Action on `master` branch commit doesn't make a big difference. And, we need to start to test at every commit as a next step. No. Manual. Closes apache#29076 from dongjoon-hyun/reenable_gha_commit. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
HyukjinKwon
pushed a commit
to HyukjinKwon/spark
that referenced
this pull request
Aug 19, 2020
This PR reenables GitHub Action on every commit as a next step. We carefully enabled GitHub Action on every PRs, and it looks good so far. As we saw at apache#29072, GitHub Action is already triggered at every commits on every PRs. Enabling GitHub Action on `master` branch commit doesn't make a big difference. And, we need to start to test at every commit as a next step. No. Manual. Closes apache#29076 from dongjoon-hyun/reenable_gha_commit. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
HyukjinKwon
pushed a commit
to HyukjinKwon/spark
that referenced
this pull request
Aug 19, 2020
This PR reenables GitHub Action on every commit as a next step. We carefully enabled GitHub Action on every PRs, and it looks good so far. As we saw at apache#29072, GitHub Action is already triggered at every commits on every PRs. Enabling GitHub Action on `master` branch commit doesn't make a big difference. And, we need to start to test at every commit as a next step. No. Manual. Closes apache#29076 from dongjoon-hyun/reenable_gha_commit. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
HyukjinKwon
pushed a commit
to HyukjinKwon/spark
that referenced
this pull request
Aug 19, 2020
This PR reenables GitHub Action on every commit as a next step. We carefully enabled GitHub Action on every PRs, and it looks good so far. As we saw at apache#29072, GitHub Action is already triggered at every commits on every PRs. Enabling GitHub Action on `master` branch commit doesn't make a big difference. And, we need to start to test at every commit as a next step. No. Manual. Closes apache#29076 from dongjoon-hyun/reenable_gha_commit. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
HyukjinKwon
pushed a commit
to HyukjinKwon/spark
that referenced
this pull request
Aug 19, 2020
This PR reenables GitHub Action on every commit as a next step. We carefully enabled GitHub Action on every PRs, and it looks good so far. As we saw at apache#29072, GitHub Action is already triggered at every commits on every PRs. Enabling GitHub Action on `master` branch commit doesn't make a big difference. And, we need to start to test at every commit as a next step. No. Manual. Closes apache#29076 from dongjoon-hyun/reenable_gha_commit. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
HyukjinKwon
pushed a commit
to HyukjinKwon/spark
that referenced
this pull request
Aug 19, 2020
This PR reenables GitHub Action on every commit as a next step. We carefully enabled GitHub Action on every PRs, and it looks good so far. As we saw at apache#29072, GitHub Action is already triggered at every commits on every PRs. Enabling GitHub Action on `master` branch commit doesn't make a big difference. And, we need to start to test at every commit as a next step. No. Manual. Closes apache#29076 from dongjoon-hyun/reenable_gha_commit. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
HyukjinKwon
pushed a commit
to HyukjinKwon/spark
that referenced
this pull request
Aug 19, 2020
This PR reenables GitHub Action on every commit as a next step. We carefully enabled GitHub Action on every PRs, and it looks good so far. As we saw at apache#29072, GitHub Action is already triggered at every commits on every PRs. Enabling GitHub Action on `master` branch commit doesn't make a big difference. And, we need to start to test at every commit as a next step. No. Manual. Closes apache#29076 from dongjoon-hyun/reenable_gha_commit. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR reenables GitHub Action on every commit as a next step.
Why are the changes needed?
We carefully enabled GitHub Action on every PRs, and it looks good so far.
As we saw at #29072, GitHub Action is already triggered at every commits on every PRs. Enabling GitHub Action on
masterbranch commit doesn't make a big difference. And, we need to start to test at every commit as a next step.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Manual.