Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-2652] [PySpark] donot use KyroSerializer as default serializer #2916

Closed
wants to merge 1 commit into from

Conversation

davies
Copy link
Contributor

@davies davies commented Oct 23, 2014

KyroSerializer can not serialize customized class without registered explicitly, use it as default serializer in PySpark will introduce some regression in MLlib.

cc @mengxr

@SparkQA
Copy link

SparkQA commented Oct 23, 2014

QA tests have started for PR 2916 at commit 43eb6d3.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Oct 24, 2014

QA tests have finished for PR 2916 at commit 43eb6d3.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/22093/
Test PASSed.

@mengxr
Copy link
Contributor

mengxr commented Oct 24, 2014

LGTM. Merged into both master and branch-1.1. Thanks!

asfgit pushed a commit that referenced this pull request Oct 24, 2014
KyroSerializer can not serialize customized class without registered explicitly, use it as default serializer in PySpark will introduce some regression in MLlib.

cc mengxr

Author: Davies Liu <davies@databricks.com>

Closes #2916 from davies/revert and squashes the following commits:

43eb6d3 [Davies Liu] donot use KyroSerializer as default serializer

(cherry picked from commit 809c785)
Signed-off-by: Xiangrui Meng <meng@databricks.com>
@asfgit asfgit closed this in 809c785 Oct 24, 2014
asfgit pushed a commit that referenced this pull request Nov 11, 2014
…rk back to Kryo

This reverts #2916 . We shouldn't change the default settings in a minor release. JoshRosen davies

Author: Xiangrui Meng <meng@databricks.com>

Closes #3187 from mengxr/SPARK-2652-1.1 and squashes the following commits:

372166b [Xiangrui Meng] change the default spark.serializer in pyspark back to Kryo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants