Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-32357][INFRA] Add a step in GitHub Actions to show failed tests #29169

Closed
wants to merge 4 commits into from

Conversation

viirya
Copy link
Member

@viirya viirya commented Jul 20, 2020

What changes were proposed in this pull request?

Currently, the readability in the logs of GitHub Actions are not really good. This proposes to add a step in GitHub Actions to show failed tests if any. This new step "Failed tests" will be triggered if previous step "Run tests: ${{ matrix.modules }}" has failure.

Why are the changes needed?

More easier to find failed tests in GitHub Actions.

Does this PR introduce any user-facing change?

No. This is for developer-only.

How was this patch tested?

Test on Github.

Screen Shot 2020-07-20 at 1 03 11 PM

@SparkQA

This comment has been minimized.

@dongjoon-hyun
Copy link
Member

dongjoon-hyun commented Jul 20, 2020

Oh. The idea looks nice, @viirya .

@dongjoon-hyun
Copy link
Member

cc @gengliangwang and @HyukjinKwon

@SparkQA

This comment has been minimized.

@SparkQA
Copy link

SparkQA commented Jul 21, 2020

Test build #126205 has finished for PR 29169 at commit 7173918.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member

Yeah, +1

@HyukjinKwon
Copy link
Member

Let me take a quick look if there are any other good easy way to do this. If there' no, let's go for this way 👍

@viirya
Copy link
Member Author

viirya commented Jul 21, 2020

Thanks @HyukjinKwon

@HyukjinKwon
Copy link
Member

Let me test out some other GitHub actions like https://github.com/check-run-reporter/action, https://github.com/ashley-taylor/junit-report-annotations-action or other ways around to see if it's feasible or not, and then come back.

@SparkQA
Copy link

SparkQA commented Jul 29, 2020

Test build #126747 has finished for PR 29169 at commit c788144.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@viirya
Copy link
Member Author

viirya commented Aug 3, 2020

@HyukjinKwon Hi, this is for a while. Do you have some more thoughts? Thanks.

@HyukjinKwon
Copy link
Member

Hey, sorry for the late responses. I just had some time to try a couple of plugins and figured out one working. I made a PR and cc'ed you there.

@viirya
Copy link
Member Author

viirya commented Aug 3, 2020

There is an existing plugin visually looking nice and seems working. Close this one.

@viirya viirya closed this Aug 3, 2020
@viirya viirya deleted the show-failed-tests branch December 27, 2023 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants