Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-32387][SS] Extract UninterruptibleThread runner logic from KafkaOffsetReader #29187

Closed
wants to merge 3 commits into from
Closed

[SPARK-32387][SS] Extract UninterruptibleThread runner logic from KafkaOffsetReader #29187

wants to merge 3 commits into from

Conversation

gaborgsomogyi
Copy link
Contributor

What changes were proposed in this pull request?

UninterruptibleThread running functionality is baked into KafkaOffsetReader which can be extracted into a class. The main intention is to simplify KafkaOffsetReader in order to make easier to solve SPARK-32032. In this PR I've made this extraction without functionality change.

Why are the changes needed?

UninterruptibleThread running functionality is baked into KafkaOffsetReader.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Existing + additional unit tests.

@gaborgsomogyi
Copy link
Contributor Author

cc @HeartSaVioR @zsxwing @xuanyuanking

@SparkQA
Copy link

SparkQA commented Jul 22, 2020

Test build #126327 has finished for PR 29187 at commit 9d214c9.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jul 22, 2020

Test build #126328 has finished for PR 29187 at commit 31c73b9.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

HeartSaVioR
HeartSaVioR reviewed Jul 22, 2020
View reviewed changes
Copy link
Contributor

@HeartSaVioR HeartSaVioR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in overall. Left some comments majorly on leaving code comments.

external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaOffsetReader.scala Show resolved Hide resolved
core/src/main/scala/org/apache/spark/util/UninterruptibleThreadRunner.scala Show resolved Hide resolved
core/src/main/scala/org/apache/spark/util/UninterruptibleThreadRunner.scala Show resolved Hide resolved
core/src/main/scala/org/apache/spark/util/UninterruptibleThreadRunner.scala Outdated Show resolved Hide resolved
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaOffsetReader.scala Show resolved Hide resolved
zsxwing
zsxwing reviewed Jul 23, 2020
View reviewed changes
Copy link
Member

@zsxwing zsxwing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me except some nits.

core/src/test/scala/org/apache/spark/util/UninterruptibleThreadRunnerSuite.scala Outdated Show resolved Hide resolved
core/src/test/scala/org/apache/spark/util/UninterruptibleThreadRunnerSuite.scala Outdated Show resolved Hide resolved
core/src/test/scala/org/apache/spark/util/UninterruptibleThreadRunnerSuite.scala Outdated Show resolved Hide resolved
@gaborgsomogyi
Copy link
Contributor Author

Thanks guys for the quick review, started to process the suggestions...

@SparkQA
Copy link

SparkQA commented Jul 23, 2020

Test build #126424 has finished for PR 29187 at commit 8e78239.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@gaborgsomogyi
Copy link
Contributor Author

retest this please

@gaborgsomogyi
Copy link
Contributor Author

Filed SPARK-32416 and SPARK-32417.

@SparkQA
Copy link

SparkQA commented Jul 23, 2020

Test build #126432 has finished for PR 29187 at commit 8e78239.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HeartSaVioR
Copy link
Contributor

Filed SPARK-32418

@HeartSaVioR
Copy link
Contributor

retest this, please

HeartSaVioR
HeartSaVioR approved these changes Jul 23, 2020
View reviewed changes
Copy link
Contributor

@HeartSaVioR HeartSaVioR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll wait for @zsxwing a bit to see whether he has more comments to add.

@SparkQA
Copy link

SparkQA commented Jul 24, 2020

Test build #126441 has finished for PR 29187 at commit 8e78239.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@xuanyuanking
Copy link
Member

LGTM

zsxwing
zsxwing approved these changes Jul 24, 2020
View reviewed changes
Copy link
Member

@zsxwing zsxwing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dongjoon-hyun
dongjoon-hyun approved these changes Jul 24, 2020
View reviewed changes
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. Thank you, @gaborgsomogyi , @HeartSaVioR , @zsxwing , @xuanyuanking .
Merged to master for Apache Spark 3.1.0 on December 2020.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zsxwing zsxwing zsxwing approved these changes

@HeartSaVioR HeartSaVioR HeartSaVioR approved these changes

@dongjoon-hyun dongjoon-hyun dongjoon-hyun approved these changes

Assignees
No one assigned
Labels
CORE DSTREAM SQL STRUCTURED STREAMING
Projects
None yet
Milestone
No milestone
6 participants
@gaborgsomogyi @SparkQA @HeartSaVioR @xuanyuanking @zsxwing @dongjoon-hyun