[SPARK-32234][FOLLOWUP][SQL]Update the description of utility method #29232
Conversation
SaurabhChawla100
changed the title
|
ok to test |
|
Test build #126541 has finished for PR 29232 at commit
|
| * resultSchemaString will be created using pruned col in case of | ||
| * canPruneCols is true and for canPruneCols as false value | ||
| * resultSchemaString will be created using the actual dataSchema. | ||
| * Also as the part of this method update the MAPRED_INPUT_SCHEMA |
There was a problem hiding this comment.
update the MAPRED_INPUT_SCHEMA -> updates the MAPRED_INPUT_SCHEMA in the given 'conf'.
There was a problem hiding this comment.
Updated the comment as suggested by @HyukjinKwon
| * resultSchemaString will be created using resultsSchema in case of | ||
| * canPruneCols is true and for canPruneCols as false value | ||
| * resultSchemaString will be created using the actual dataSchema. | ||
| * This method returns the result schema as string based on the canPruneCols flag. |
There was a problem hiding this comment.
I would just write as:
Returns the result schema to read from ORC file. In addition, It sets the schema string to 'orc.mapred.input.schema' so ORC readers can use later.
and inline the details about parameters into the parameter descriptions below.
There was a problem hiding this comment.
that looks fine. Will update as suggested
|
Test build #126609 has finished for PR 29232 at commit
|
|
retest this please |
|
github action passes, merging to master, thanks! |
|
Test build #126628 has finished for PR 29232 at commit
|
What changes were proposed in this pull request?
As the part of this PR #29045 added the helper method. This PR is the FOLLOWUP PR to update the description of helper method.
Why are the changes needed?
For better readability and understanding of the code
Does this PR introduce any user-facing change?
No
How was this patch tested?
Since its only change of updating the description , So ran the Spark shell