-
Notifications
You must be signed in to change notification settings - Fork 28k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-32499][SQL] Use {}
in conversions maps and structs to strings
#29308
Conversation
Test build #126805 has finished for PR 29308 at commit
|
@maropu @cloud-fan Please, review this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Test build #126977 has finished for PR 29308 at commit
|
Test build #126991 has finished for PR 29308 at commit
|
Test build #127007 has finished for PR 29308 at commit
|
Test build #127035 has finished for PR 29308 at commit
|
Test build #127042 has finished for PR 29308 at commit
|
Test build #127048 has finished for PR 29308 at commit
|
thanks, merging to master! |
What changes were proposed in this pull request?
Change casting of map and struct values to strings by using the
{}
brackets instead of[]
. The behavior is controlled by the SQL configspark.sql.legacy.castComplexTypesToString.enabled
. When it istrue
,CAST
wraps maps and structs by[]
in casting to strings. Otherwise, if this isfalse
, which is the default, maps and structs are wrapped by{}
.Why are the changes needed?
show
's output consistent with Hive and conversions to Hive strings.spark-sql
andshow
*.sql
testsDoes this PR introduce any user-facing change?
Yes
How was this patch tested?
By existing test suite
CastSuite
.