[SPARK-32560][SQL]Improve exception message at InsertIntoHiveTable.processInsert #29376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update masterbranch
|
ok to test |
|
Looks okay if the tests pass. |
HyukjinKwon
approved these changes
Aug 7, 2020
HyukjinKwon
reviewed
Aug 7, 2020
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/InsertIntoHiveTable.scala
Outdated
Show resolved
Hide resolved
|
Test build #127162 has finished for PR 29376 at commit
|
|
Test build #127168 has finished for PR 29376 at commit
|
HyukjinKwon
changed the title
|
The tests passed at #29376 (comment). |
HyukjinKwon
pushed a commit
that referenced
this pull request
Aug 7, 2020
…rocessInsert ### What changes were proposed in this pull request? improve exception message ### Why are the changes needed? the before message lack of single quotes, we may improve it to keep consisent.  ### Does this PR introduce _any_ user-facing change? NO ### How was this patch tested? No ,it is only improving the message. Closes #29376 from GuoPhilipse/improve-exception-message. Lead-authored-by: GuoPhilipse <46367746+GuoPhilipse@users.noreply.github.com> Co-authored-by: GuoPhilipse <guofei_ok@126.com> Signed-off-by: HyukjinKwon <gurwls223@apache.org> (cherry picked from commit aa4d3c1) Signed-off-by: HyukjinKwon <gurwls223@apache.org>
|
Merged to master, branch-3.0 and branch-2.4. |
HyukjinKwon
pushed a commit
that referenced
this pull request
Aug 7, 2020
…rocessInsert ### What changes were proposed in this pull request? improve exception message ### Why are the changes needed? the before message lack of single quotes, we may improve it to keep consisent.  ### Does this PR introduce _any_ user-facing change? NO ### How was this patch tested? No ,it is only improving the message. Closes #29376 from GuoPhilipse/improve-exception-message. Lead-authored-by: GuoPhilipse <46367746+GuoPhilipse@users.noreply.github.com> Co-authored-by: GuoPhilipse <guofei_ok@126.com> Signed-off-by: HyukjinKwon <gurwls223@apache.org> (cherry picked from commit aa4d3c1) Signed-off-by: HyukjinKwon <gurwls223@apache.org>
|
cc @ScrapCodes and @zhengruifeng. This is very trivial but I cc'ed you guys since RC1 2.4 came out and you guys will probably be keen about the changes coming :-). |
|
Test build #127175 has finished for PR 29376 at commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
improve exception message
Why are the changes needed?
the before message lack of single quotes, we may improve it to keep consisent.
Does this PR introduce any user-facing change?
NO
How was this patch tested?
No ,it is only improving the message.