[SPARK-32651][CORE] Decommission switch configuration should have the highest hierarchy #29466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cloud-fan @holdenk @agrawaldevesh Please take a look, thanks! |
|
Test build #127581 has finished for PR 29466 at commit
|
|
Test build #127582 has finished for PR 29466 at commit
|
|
Test build #127583 has finished for PR 29466 at commit
|
agrawaldevesh
approved these changes
Aug 18, 2020
| .doc("When decommission enabled, Spark will try its best to shutdown the executor " + | ||
| s"gracefully. Spark will try to migrate all the RDD blocks (controlled by " + | ||
| s"${STORAGE_DECOMMISSION_RDD_BLOCKS_ENABLED.key}) and shuffle blocks (controlled by " + | ||
| s"${STORAGE_DECOMMISSION_SHUFFLE_BLOCKS_ENABLED.key}) from the decommissioning " + |
There was a problem hiding this comment.
nit: some 2 spaces here ... before from
There was a problem hiding this comment.
Yeah. Sorry. Fonts are misleading :-)
core/src/main/scala/org/apache/spark/internal/config/package.scala
Outdated
Show resolved
Hide resolved
I think no..I'll double check tomorrow. |
I can't find any other config too. LGTM. |
|
Test build #127591 has finished for PR 29466 at commit
|
|
thanks, merging to master! |
This was referenced Aug 19, 2020
Closed
holdenk
pushed a commit
to holdenk/spark
that referenced
this pull request
Oct 27, 2020
… highest hierarchy Rename `spark.worker.decommission.enabled` to `spark.decommission.enabled` and move it from `org.apache.spark.internal.config.Worker` to `org.apache.spark.internal.config.package`. Decommission has been supported in Standalone and k8s yet and may be supported in Yarn(apache#27636) in the future. Therefore, the switch configuration should have the highest hierarchy rather than belongs to Standalone's Worker. In other words, it should be independent of the cluster managers. No, as the decommission feature hasn't been released. Pass existed tests. Closes apache#29466 from Ngone51/fix-decom-conf. Authored-by: yi.wu <yi.wu@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Rename
spark.worker.decommission.enabledtospark.decommission.enabledand move it fromorg.apache.spark.internal.config.Workertoorg.apache.spark.internal.config.package.Why are the changes needed?
Decommission has been supported in Standalone and k8s yet and may be supported in Yarn(#27636) in the future. Therefore, the switch configuration should have the highest hierarchy rather than belongs to Standalone's Worker. In other words, it should be independent of the cluster managers.
Does this PR introduce any user-facing change?
No, as the decommission feature hasn't been released.
How was this patch tested?
Pass existed tests.