New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-32667][SQL] Script transform 'default-serde' mode should pad null value to filling column #29500
Conversation
cc @cloud-fan |
Test build #127712 has finished for PR 29500 at commit
|
The patch LGTM, but I have a question about the terminology here. AFAIK no-serde in Hive means a default serde is picked. Shall we use "default-serde mode" instead of "no-serde mode"? |
Yea |
thanks, merging to master! |
@@ -372,6 +372,35 @@ abstract class BaseScriptTransformationSuite extends SparkPlanTest with SQLTestU | |||
'e.cast("string"))).collect()) | |||
} | |||
} | |||
|
|||
test("SPARK-32667: SCRIPT TRANSFORM pad null value to fill column" + | |||
" when without schema less (no-serde)") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please update "no-serde" in the codebase in your other TRANSFORM PRs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please update "no-serde" in the codebase in your other TRANSFORM PRs.
Will raise a pr to handle this together
What changes were proposed in this pull request?
Hive no serde mode when column less then output specified column, it will pad null value to it, spark should do this also.
Why are the changes needed?
Keep save behavior with hive data.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Added UT