[SPARK-32950][SQL] Remove unnecessary big-endian code paths. #29815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mundaym
commented
Sep 21, 2020
| } | ||
| } | ||
| Platform.copyMemory(src, Platform.BYTE_ARRAY_OFFSET + srcIndex, floatData, | ||
| Platform.DOUBLE_ARRAY_OFFSET + rowId * 4L, count * 4L); |
There was a problem hiding this comment.
Existing bug, but should this be FLOAT_ARRAY_OFFSET (I guess they are the same value)? I can fix this here or can do a separate PR.
There was a problem hiding this comment.
It seems Ok to fix here. I presume they are in fact the same, so it has worked to date.
srowen
approved these changes
Sep 21, 2020
| } | ||
| } | ||
| Platform.copyMemory(src, Platform.BYTE_ARRAY_OFFSET + srcIndex, floatData, | ||
| Platform.DOUBLE_ARRAY_OFFSET + rowId * 4L, count * 4L); |
There was a problem hiding this comment.
It seems Ok to fix here. I presume they are in fact the same, so it has worked to date.
|
Jenkins test this please |
There is no need for separate code paths for big- and little-endian platforms in putDoubles and putFloats anymore (since PR apache#24861). On all platforms values are encoded in native byte order and can just be copied directly. Also, fix a typo where DOUBLE_ARRAY_OFFSET was used instead of FLOAT_ARRAY_OFFSET.
mundaym
force-pushed
the
clean-putfloats
branch
from
ce27770
to
bd4b640
Compare
|
Test build #128937 has finished for PR 29815 at commit
|
|
Merged to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Remove unnecessary code.
Why are the changes needed?
General housekeeping. Might be a slight performance improvement, especially on big-endian systems.
There is no need for separate code paths for big- and little-endian
platforms in putDoubles and putFloats anymore (since PR #24861). On
all platforms values are encoded in native byte order and can just
be copied directly.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing tests.