Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-32889][SQL][TESTS][FOLLOWUP] Skip special column names test in Hive 1.2 #29867

Closed
wants to merge 1 commit into from
Closed

[SPARK-32889][SQL][TESTS][FOLLOWUP] Skip special column names test in Hive 1.2 #29867

wants to merge 1 commit into from

Conversation

dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Sep 24, 2020

What changes were proposed in this pull request?

This PR is a followup of SPARK-32889 in order to ignore the special column names test in hive-1.2 profile.

Why are the changes needed?

Hive 1.2 is too old to support special column names because it doesn't use Apache ORC. This will recover our hive-1.2 Jenkins job.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Pass the test with Hive 1.2 profile.

@dongjoon-hyun dongjoon-hyun changed the title [SPARK-32889][SQL][TESTS][FOLLOWUP] Skip special columns name test in Hive 1.2 [SPARK-32889][SQL][TESTS][FOLLOWUP] Skip special column name test in Hive 1.2 Sep 24, 2020
@dongjoon-hyun dongjoon-hyun changed the title [SPARK-32889][SQL][TESTS][FOLLOWUP] Skip special column name test in Hive 1.2 [SPARK-32889][SQL][TESTS][FOLLOWUP] Skip special column names test in Hive 1.2 Sep 24, 2020
@dongjoon-hyun dongjoon-hyun changed the title [SPARK-32889][SQL][TESTS][FOLLOWUP] Skip special column names test in Hive 1.2 [SPARK-32889][SQL][TESTS][FOLLOWUP][test-hadoop2.7][test-hive1.2] Skip special column names test in Hive 1.2 Sep 24, 2020
@dongjoon-hyun
Copy link
Member Author

Retest this please.

@SparkQA
Copy link

SparkQA commented Sep 24, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33708/

@SparkQA
Copy link

SparkQA commented Sep 24, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33710/

@SparkQA
Copy link

SparkQA commented Sep 24, 2020

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33708/

@SparkQA
Copy link

SparkQA commented Sep 24, 2020

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33710/

@dongjoon-hyun
Copy link
Member Author

Thank you, @HyukjinKwon !

@dongjoon-hyun
Copy link
Member Author

The Jenkins jobs are passing Scala/Java tests already. Merged to master.

@dongjoon-hyun dongjoon-hyun changed the title [SPARK-32889][SQL][TESTS][FOLLOWUP][test-hadoop2.7][test-hive1.2] Skip special column names test in Hive 1.2 [SPARK-32889][SQL][TESTS][FOLLOWUP] Skip special column names test in Hive 1.2 Sep 24, 2020
@dongjoon-hyun dongjoon-hyun deleted the SPARK-32889-2 branch September 24, 2020 23:22
@SparkQA
Copy link

SparkQA commented Sep 24, 2020

Test build #129087 has finished for PR 29867 at commit 910c1b9.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Sep 24, 2020

Test build #129089 has finished for PR 29867 at commit 910c1b9.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants