Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-32714][FOLLOW-UP][PYTHON] Address pyspark.install typing errors #29878

Closed
wants to merge 1 commit into from

Conversation

zero323
Copy link
Member

@zero323 zero323 commented Sep 26, 2020

What changes were proposed in this pull request?

This PR adds two type: ignores, one in pyspark.install and one in related tests.

Why are the changes needed?

To satisfy MyPy type checks. It seems like we originally missed some changes that happened around merge of
31a16fb

python/pyspark/install.py:30: error: Need type annotation for 'UNSUPPORTED_COMBINATIONS' (hint: "UNSUPPORTED_COMBINATIONS: List[<type>] = ...")  [var-annotated]
python/pyspark/tests/test_install_spark.py:105: error: Cannot find implementation or library stub for module named 'xmlrunner'  [import]
python/pyspark/tests/test_install_spark.py:105: note: See https://mypy.readthedocs.io/en/latest/running_mypy.html#missing-imports

Does this PR introduce any user-facing change?

No.

How was this patch tested?

  • Existing tests.
  • MyPy tests
    mypy --show-error-code --no-incremental --config python/mypy.ini python/pyspark
    

@zero323
Copy link
Member Author

zero323 commented Sep 26, 2020

cc @HyukjinKwon

@SparkQA
Copy link

SparkQA commented Sep 26, 2020

Test build #129136 has finished for PR 29878 at commit fb89746.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@zero323 zero323 changed the title [SPARK-32714][FOLLOW-UP] Address pyspark.install typing errors [SPARK-32714][FOLLOW-UP][PYTHON] Address pyspark.install typing errors Sep 26, 2020
@SparkQA
Copy link

SparkQA commented Sep 26, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33752/

@SparkQA
Copy link

SparkQA commented Sep 26, 2020

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33752/

@HyukjinKwon
Copy link
Member

Thanks, @zero323. Merged to master.

@zero323 zero323 deleted the SPARK-32714-FOLLOW-UP branch September 27, 2020 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants