-
Notifications
You must be signed in to change notification settings - Fork 28.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-27951][SQL][FOLLOWUP] Improve the window function nth_value #29886
Conversation
Kubernetes integration test starting |
Kubernetes integration test status success |
sql/core/src/test/resources/sql-tests/results/postgreSQL/window_part3.sql.out
Outdated
Show resolved
Hide resolved
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala
Show resolved
Hide resolved
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala
Outdated
Show resolved
Hide resolved
Test build #129163 has finished for PR 29886 at commit
|
Test build #129167 has finished for PR 29886 at commit
|
Test build #129166 has finished for PR 29886 at commit
|
Kubernetes integration test starting |
retest this please |
Kubernetes integration test status success |
Kubernetes integration test starting |
Kubernetes integration test status success |
Kubernetes integration test starting |
Kubernetes integration test status failure |
Test build #129170 has finished for PR 29886 at commit
|
Merged to master. |
@HyukjinKwon @cloud-fan Thanks! |
What changes were proposed in this pull request?
#29604 supports the ANSI SQL NTH_VALUE.
We should override the
prettyName
andsql
.Why are the changes needed?
Make the name of nth_value correct.
To show the ignoreNulls parameter correctly.
Does this PR introduce any user-facing change?
'No'.
How was this patch tested?
Jenkins test.