Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-33049][CORE] Decommission shuffle block test is flaky #29929

Conversation

holdenk
Copy link
Contributor

@holdenk holdenk commented Oct 2, 2020

What changes were proposed in this pull request?

Increase the listener bus event length, syncrhonize the addition of blocks modified to the array list.

Why are the changes needed?

This test appears flaky in Jenkins (can not repro locally). Given that the index file made it through and the index file is only transferred after the data file, the only two reasons I could come up with an interminentent failure here are with the listenerbus dropping a message or the two block change messages being received at the same time.

Does this PR introduce any user-facing change?

No (test only).

How was this patch tested?

The tests still pass on my machine but they did before. We'll need to run it through jenkins a few times first.

@holdenk holdenk changed the title [WIP] Decommission shuffle block test is flaky [WIP][CORE] Decommission shuffle block test is flaky Oct 2, 2020
@holdenk holdenk changed the title [WIP][CORE] Decommission shuffle block test is flaky [WIP][CORE][SPARK-33049] Decommission shuffle block test is flaky Oct 2, 2020
@SparkQA
Copy link

SparkQA commented Oct 2, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33941/

@SparkQA
Copy link

SparkQA commented Oct 2, 2020

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33941/

@SparkQA
Copy link

SparkQA commented Oct 2, 2020

Test build #129328 has finished for PR 29929 at commit 6518153.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@holdenk
Copy link
Contributor Author

holdenk commented Oct 2, 2020

jenkins retest this please

@holdenk
Copy link
Contributor Author

holdenk commented Oct 2, 2020

cc @dongjoon-hyun

@SparkQA
Copy link

SparkQA commented Oct 2, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33947/

@SparkQA
Copy link

SparkQA commented Oct 2, 2020

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33947/

@SparkQA
Copy link

SparkQA commented Oct 2, 2020

Test build #129334 has finished for PR 29929 at commit 6518153.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds no public classes.

@holdenk
Copy link
Contributor Author

holdenk commented Oct 2, 2020

Jenkins failure is unrelated.
Jenkins retest this please.

@dongjoon-hyun
Copy link
Member

Retest this please.

@dongjoon-hyun dongjoon-hyun changed the title [WIP][CORE][SPARK-33049] Decommission shuffle block test is flaky [CORE][SPARK-33049] Decommission shuffle block test is flaky Oct 3, 2020
@dongjoon-hyun dongjoon-hyun changed the title [CORE][SPARK-33049] Decommission shuffle block test is flaky [SPARK-33049][CORE] Decommission shuffle block test is flaky Oct 3, 2020
@dongjoon-hyun
Copy link
Member

Thank you, @holdenk . Merged to master for Apache Spark 3.1.0.

@SparkQA
Copy link

SparkQA commented Oct 4, 2020

Test build #129386 has finished for PR 29929 at commit 6518153.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants