Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-32793][FOLLOW-UP] Minor corrections for PySpark annotations and SparkR #29978

Closed
wants to merge 3 commits into from

Conversation

zero323
Copy link
Member

@zero323 zero323 commented Oct 8, 2020

What changes were proposed in this pull request?

  • Annotated return types of assert_true and raise_error as discussed here.
  • Add assert_true and raise_error to SparkR NAMESPACE.
  • Validating message vector size in SparkR as discussed here.

Why are the changes needed?

As discussed in review for #29947.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

  • Existing tests.
  • Validation of annotations using MyPy

@SparkQA
Copy link

SparkQA commented Oct 8, 2020

Test build #129559 has finished for PR 29978 at commit 4da2633.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Oct 8, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34165/

@zero323

This comment has been minimized.

@SparkQA
Copy link

SparkQA commented Oct 8, 2020

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34165/

@zero323 zero323 closed this Oct 8, 2020
@zero323 zero323 reopened this Oct 8, 2020
@HyukjinKwon
Copy link
Member

Merged to master.

@zero323
Copy link
Member Author

zero323 commented Oct 9, 2020

Thanks @HyukjinKwon

@zero323 zero323 deleted the SPARK-32793-FOLLOW-UP branch October 9, 2020 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants