Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-33216][INFRA][PYTHON][2.4] Set upper bound of Pandas version in GitHub Actions #30127

Closed
wants to merge 2 commits into from

Conversation

dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Oct 22, 2020

What changes were proposed in this pull request?

This PR aims to pin Pandas version up to 1.1.0 released on July 28.

Why are the changes needed?

branch-2.4 GitHub Action was broken since Aug 26 due to Pandas API incompatibility.

The following is just one example.

File "/home/runner/work/spark/spark/python/pyspark/sql/tests.py", line 5948, in change_col_order
    return pd.DataFrame.from_items([
AttributeError: type object 'DataFrame' has no attribute 'from_items'

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Pass the GitHub Action.

@dongjoon-hyun dongjoon-hyun changed the title [WIP][INFRA][PYTHON][2.4] Set upper bound of Pandas version in GitHub Actions [SPARK-33216][INFRA][PYTHON][2.4] Set upper bound of Pandas version in GitHub Actions Oct 22, 2020
@dongjoon-hyun
Copy link
Member Author

dongjoon-hyun commented Oct 22, 2020

@HyukjinKwon How do you think about this? branch-2.4 GitHub Action seems to be broken for a while.

@SparkQA
Copy link

SparkQA commented Oct 22, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34728/

@dongjoon-hyun
Copy link
Member Author

@HyukjinKwon . I'll close this PR in favor of SPARK-30777.

@dongjoon-hyun dongjoon-hyun deleted the FIX_PANDAS branch October 22, 2020 03:14
@dongjoon-hyun
Copy link
Member Author

Please recover branch-2.4~ Thank you in advance.

@HyukjinKwon
Copy link
Member

Ohh okay got it. There are more tests being failed.

@HyukjinKwon
Copy link
Member

Some of them require Arrow dep upgrade in pom which isn't possible. I thought I fixed it by setting upper bound of PyArrow. Hm, let me fix it by the same approach proposed here.

@SparkQA
Copy link

SparkQA commented Oct 22, 2020

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34728/

@dongjoon-hyun dongjoon-hyun restored the FIX_PANDAS branch October 22, 2020 03:36
@dongjoon-hyun dongjoon-hyun reopened this Oct 22, 2020
@HyukjinKwon
Copy link
Member

HyukjinKwon commented Oct 22, 2020

I discussed offline with @dongjoon-hyun. It requires to port at least two PRs 07a9885 and 16990f9 + Arrow dependency upgrade in POM side which is not possible. Setting the upper bound looks correct approach. It was my bad that I thought it just needs one backport.

@dongjoon-hyun
Copy link
Member Author

Thank you for investigating all the stuff and guiding this, @HyukjinKwon !

Copy link
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM: it can just set to whichever pandas version that makes the build in branch-2.4

@SparkQA
Copy link

SparkQA commented Oct 22, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34729/

@HyukjinKwon
Copy link
Member

@dongjoon-hyun, I will open another PR with picking your commits - seems it fails.

@HyukjinKwon HyukjinKwon deleted the FIX_PANDAS branch October 22, 2020 04:10
@SparkQA
Copy link

SparkQA commented Oct 22, 2020

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34729/

@SparkQA
Copy link

SparkQA commented Oct 22, 2020

Test build #130121 has finished for PR 30127 at commit 260a5d5.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Oct 22, 2020

Test build #130120 has finished for PR 30127 at commit 9729565.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Oct 22, 2020

Test build #130122 has finished for PR 30127 at commit 260a5d5.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants