[SPARK-33458][SQL] Hive partition pruning support Contains, StartsWith and EndsWith predicate #30383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kubernetes integration test starting |
|
Kubernetes integration test status success |
|
Test build #131123 has finished for PR 30383 at commit
|
cloud-fan
approved these changes
Nov 16, 2020
|
thanks, merging to master! |
gatorsmile
reviewed
Nov 18, 2020
| case StartsWith(ExtractAttribute(SupportedAttribute(name)), ExtractableLiteral(value)) => | ||
| Some(s"$name like " + (value.dropRight(1) + ".*\"")) | ||
|
|
||
| case EndsWith(ExtractAttribute(SupportedAttribute(name)), ExtractableLiteral(value)) => |
There was a problem hiding this comment.
@wangyum Can we add test cases to ensure all the Hive metastore versions support them?
There was a problem hiding this comment.
It should have been tested from Hive 0.13 to Hive 3.1: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131123/testReport/org.apache.spark.sql.hive.client/HivePartitionFilteringSuite/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pr add support Hive partition pruning on
Contains,StartsWithandEndsWithpredicate.Why are the changes needed?
Improve query performance.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Unit test.