[SPARK-32670][SQL][FOLLOWUP] Group exception messages in Catalyst Analyzer in one file #30564
Conversation
|
Kubernetes integration test status success |
|
Test build #132407 has finished for PR 30564 at commit
|
|
retest this please |
|
Test build #132425 has finished for PR 30564 at commit
|
|
retest this please |
|
Test build #132433 has finished for PR 30564 at commit
|
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
|
The hive thrift server tests seem to have issues: |
|
retest this please |
|
Kubernetes integration test starting |
|
Test build #132465 has finished for PR 30564 at commit
|
| def expressionWithMultiWindowExpressionsError( | ||
| expr: NamedExpression, distinctWindowSpec: Seq[WindowSpecDefinition]): Throwable = { | ||
| new AnalysisException(s"$expr has multiple Window Specifications ($distinctWindowSpec)." + | ||
| s"Please file a bug report with this error message, stack trace, and the query.") |
| def windowFunctionWithWindowFrameNotOrderedError(wf: WindowFunction): Throwable = { | ||
| new AnalysisException(s"Window function $wf requires window to be ordered, please add " + | ||
| s"ORDER BY clause. For example SELECT $wf(value_expr) OVER (PARTITION BY window_partition " + | ||
| s"ORDER BY window_ordering) from table") |
|
|
||
| def writeTableWithMismatchedColumnsError( | ||
| columnSize: Int, outputSize: Int, t: TreeNode[_]): Throwable = { | ||
| new AnalysisException(s"Cannot write to table due to mismatched user specified column " + |
|
Kubernetes integration test status success |
|
Kubernetes integration test starting |
|
Kubernetes integration test status success |
|
Test build #132472 has finished for PR 30564 at commit
|
|
retest this please |
|
Kubernetes integration test starting |
|
Kubernetes integration test status success |
|
Test build #132486 has finished for PR 30564 at commit
|
|
retest this please |
|
Kubernetes integration test starting |
|
Kubernetes integration test status success |
|
Test build #132527 has finished for PR 30564 at commit
|
|
thanks, merging to master! |
|
@cloud-fan Thanks for your work! |
What changes were proposed in this pull request?
This PR follows up #29497.
Because #29497 just give us an example to group all
AnalysisExcpetionin Analyzer into QueryCompilationErrors.This PR group other
AnalysisExcpetioninto QueryCompilationErrors.Why are the changes needed?
It will largely help with standardization of error messages and its maintenance.
Does this PR introduce any user-facing change?
No. Error messages remain unchanged.
How was this patch tested?
No new tests - pass all original tests to make sure it doesn't break any existing behavior.