Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-33472][SQL][FOLLOW-UP] Update RemoveRedundantSorts comment #30584

Closed

Conversation

allisonwang-db
Copy link
Contributor

What changes were proposed in this pull request?

This PR is a follow-up for #30373 that updates the comment for RemoveRedundantSorts in QueryExecution.

Why are the changes needed?

To update an incorrect comment.

Does this PR introduce any user-facing change?

No

How was this patch tested?

N/A

@github-actions github-actions bot added the SQL label Dec 3, 2020
@SparkQA
Copy link

SparkQA commented Dec 3, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36693/

@SparkQA
Copy link

SparkQA commented Dec 3, 2020

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36693/

@SparkQA
Copy link

SparkQA commented Dec 3, 2020

Test build #132094 has finished for PR 30584 at commit 4f16499.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@allisonwang-db
Copy link
Contributor Author

cc @maropu

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. Thank you, @alismess-db .
cc @gatorsmile

dongjoon-hyun pushed a commit that referenced this pull request Dec 4, 2020
### What changes were proposed in this pull request?
This PR is a follow-up for #30373 that updates the comment for RemoveRedundantSorts in QueryExecution.

### Why are the changes needed?
To update an incorrect comment.

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
N/A

Closes #30584 from allisonwang-db/spark-33472-followup.

Authored-by: allisonwang-db <66282705+allisonwang-db@users.noreply.github.com>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
(cherry picked from commit 960d6af)
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
@maropu
Copy link
Member

maropu commented Dec 7, 2020

Thanks for the update, @allisonwang-db

@allisonwang-db allisonwang-db deleted the spark-33472-followup branch January 19, 2024 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants