Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-33675][INFRA] Add GitHub Action job to publish snapshot #30623

Closed
wants to merge 2 commits into from
Closed

[SPARK-33675][INFRA] Add GitHub Action job to publish snapshot #30623

wants to merge 2 commits into from

Conversation

dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Dec 6, 2020

What changes were proposed in this pull request?

This PR aims to add GitHub Action job to publish daily snapshot for master branch.

For the other branches, I'll make adjusted backports.

Why are the changes needed?

After this series of jobs, this will reduce our maintenance burden permanently from AmpLab Jenkins by removing the following completely.

https://amplab.cs.berkeley.edu/jenkins/view/Spark%20Packaging/

For now, AmpLab Jenkins doesn't have a job for branch-3.1. We can do it by ourselves by GitHub Action.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

The snapshot publishing is tested here at PR trigger. Since this PR adds a scheduled job, we cannot test in this PR.

Apache Infra team finished the setup here.

@SparkQA
Copy link

SparkQA commented Dec 6, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36888/

@SparkQA
Copy link

SparkQA commented Dec 6, 2020

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36888/

@HyukjinKwon
Copy link
Member

HyukjinKwon commented Dec 6, 2020

Oh actually @wangyum managed to do it with GitHub packages in his fork. Maybe we could take a look and see if we can leverage that. Will take a close look tomorrow but I support this change.

@dongjoon-hyun
Copy link
Member Author

Thanks for information. Yes, we need an official one.

@dongjoon-hyun
Copy link
Member Author

dongjoon-hyun commented Dec 6, 2020

BTW, Apache Infra team finished the setup. (INFRA-21167). This PR is ready.

@SparkQA
Copy link

SparkQA commented Dec 6, 2020

Test build #132288 has finished for PR 30623 at commit 941dc23.

  • This patch fails SparkR unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun
Copy link
Member Author

Retest this please.

@SparkQA
Copy link

SparkQA commented Dec 6, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36902/

@SparkQA
Copy link

SparkQA commented Dec 6, 2020

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36902/

@SparkQA
Copy link

SparkQA commented Dec 7, 2020

Test build #132302 has finished for PR 30623 at commit 941dc23.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. At least seems there's a downside of using GitHub packages: seems still beta and it requires a token (read-only read:packages scope) to use. We could think about switching it later when it can be seamlessly used by just adding the repo (https://github.community/t/download-from-github-package-registry-without-authentication/14407/73).

@HyukjinKwon
Copy link
Member

HyukjinKwon commented Dec 7, 2020

Merged to master and branch-3.1.

HyukjinKwon pushed a commit that referenced this pull request Dec 7, 2020
### What changes were proposed in this pull request?

This PR aims to add `GitHub Action` job to publish daily snapshot for **master** branch.
- https://repository.apache.org/content/groups/snapshots/org/apache/spark/spark-core_2.12/3.2.0-SNAPSHOT/

For the other branches, I'll make adjusted backports.
- For `branch-3.1`, we can specify the checkout `ref` to `branch-3.1`.
- For `branch-2.4` and `branch-3.0`, we can publish at every commit since the traffic is low.
  - #30630 (branch-3.0)
  - #30629 (branch-2.4 LTS)

### Why are the changes needed?

After this series of jobs, this will reduce our maintenance burden permanently from AmpLab Jenkins by removing the following completely.

https://amplab.cs.berkeley.edu/jenkins/view/Spark%20Packaging/

For now, AmpLab Jenkins doesn't have a job for `branch-3.1`. We can do it by ourselves by `GitHub Action`.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

The snapshot publishing is tested here at PR trigger. Since this PR adds a scheduled job, we cannot test in this PR.
- https://github.com/dongjoon-hyun/spark/runs/1505792859

Apache Infra team finished the setup here.
- https://issues.apache.org/jira/browse/INFRA-21167

Closes #30623 from dongjoon-hyun/SPARK-33675.

Authored-by: Dongjoon Hyun <dongjoon@apache.org>
Signed-off-by: HyukjinKwon <gurwls223@apache.org>
@SparkQA
Copy link

SparkQA commented Dec 7, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36907/

@SparkQA
Copy link

SparkQA commented Dec 7, 2020

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36907/

@SparkQA
Copy link

SparkQA commented Dec 7, 2020

Test build #132307 has finished for PR 30623 at commit 5d99242.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants